Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded build/numbers in *-mutex packages #116

Open
jakirkham opened this issue Jul 20, 2023 · 1 comment
Open

Hard-coded build/numbers in *-mutex packages #116

jakirkham opened this issue Jul 20, 2023 · 1 comment

Comments

@jakirkham
Copy link
Member

jakirkham commented Jul 20, 2023

It appears there are build/numbers (though could be misreading this) that are hard-coded in the *-mutex packages. For example

- name: _py-xgboost-mutex
version: 2.0
build:
string: cpu_0 # [cuda_compiler_version == "None"]
string: gpu_0 # [cuda_compiler_version != "None"]

- name: _r-xgboost-mutex
version: 2.0
build:
string: cpu_0 # [cuda_compiler_version == "None"]
string: gpu_0 # [cuda_compiler_version != "None"]

Should these be templated with a number Jinja variable? Or do these serve some other purpose?

Edit: For context these were added in commit ( 6d81868 ) of PR ( #15 ) and have remained largely unchanged

@jakirkham
Copy link
Member Author

Note this issue is still present. Though the code on these lines has changed

- name: _py-xgboost-mutex
version: 2.0
build:
string: {{ "cpu" if cuda_compiler == "None" else "gpu" }}_0

- name: _r-xgboost-mutex
version: 2.0
build:
string: {{ "cpu" if cuda_compiler == "None" else "gpu" }}_0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant