Skip to content

wxwidgets v3.3.1#61

Merged
pauldmccarthy merged 5 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:3.3.1_h4a3475
Jul 23, 2025
Merged

wxwidgets v3.3.1#61
pauldmccarthy merged 5 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:3.3.1_h4a3475

Conversation

@regro-cf-autotick-bot
Copy link
Copy Markdown
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
libjpeg-turbo 9f Anaconda-Server Badge

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/16421499404 - please use this URL for debugging.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@pauldmccarthy
Copy link
Copy Markdown
Contributor

Hi @hmaarrfk @h-vetinari, I think this failure might be due to the recent vs2022 migration - it seems that cmake isn't finding the vs2022 compiler, but is finding clang instead? I'm afraid I'm out of my depth on Windows - can you spot anything wrong with the recipe? Thanks in advance.

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1292943&view=logs&j=fe7faf59-69bb-5487-b8fd-a35a7bda3a51&t=55731638-dd49-5144-2129-5101b9dd1960&l=1292

@hmaarrfk
Copy link
Copy Markdown
Contributor

Hi @hmaarrfk @h-vetinari, I think this failure might be due to the recent vs2022 migration - it seems that cmake isn't finding the vs2022 compiler, but is finding clang instead? I'm afraid I'm out of my depth on Windows - can you spot anything wrong with the recipe? Thanks in advance.

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1292943&view=logs&j=fe7faf59-69bb-5487-b8fd-a35a7bda3a51&t=55731638-dd49-5144-2129-5101b9dd1960&l=1292

I'm really not sure either. I would suggest getting a real windows machine installed with VS2022 and seeing what happens if you can.

@h-vetinari
Copy link
Copy Markdown
Member

It's an issue with the compiler activation on windows. It's very strange because according to the logs the value of CMAKE_ARGS gets set correctly during activation, but then it's empty once you call it in bld.bat.

@hmaarrfk
Copy link
Copy Markdown
Contributor

Thanks h-vetinari!

@pauldmccarthy
Copy link
Copy Markdown
Contributor

@h-vetinari @hmaarrfk thanks very much!

@hmaarrfk
Copy link
Copy Markdown
Contributor

I feel like it failed after the move command. But I couldn’t tell why. We don’t check success of the move command (we should) so it must be the build procedure itself.

@pauldmccarthy
Copy link
Copy Markdown
Contributor

I don't understand the rationale, but this change causes the .dll files to be installed into bin and not lib ...

wxWidgets/wxWidgets#25643 (comment)

@pauldmccarthy
Copy link
Copy Markdown
Contributor

pauldmccarthy commented Jul 22, 2025

@hmaarrfk it's definitely the move command - the DLL files have been installed into a different location. At the moment I suspect that the linked changes in the wxWidgets .cmake files are a mistake (use of wxUSE_MSVC_NAMING instead of WIN32_MSVC_NAMING, so may end up reverting the change that I've made to bld.bat.

@hmaarrfk
Copy link
Copy Markdown
Contributor

@hmaarrfk it's definitely the move command - the DLL files have been installed into a different location. At the moment I suspect that the linked changes in the wxWidgets .cmake files are a mistake (use of wxUSE_MSVC_NAMING instead of WIN32_MSVC_NAMING, so may end up reverting the change that I've made to bld.bat.

I've had a really hard time getting the names of the libraries to be consistent on windows. It seems that upstream is having growing pains in this as I've seen it flip flop alot.

If you do get to the bottom of it, and are able to pinpoint things that would be great!

@pauldmccarthy
Copy link
Copy Markdown
Contributor

@hmaarrfk yep, it was a typo :) I've added a patch/work-around which can be removed in the next release...

wxWidgets/wxWidgets#25643 (comment)

@pauldmccarthy pauldmccarthy merged commit 33acdd0 into conda-forge:main Jul 23, 2025
9 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 3.3.1_h4a3475 branch July 23, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants