update CMAKE_ARGS in one go in activate.bat#104
Merged
Conversation
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16430037491. Examine the logs at this URL for more detail. |
Contributor
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
1 task
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In conda-forge/wxwidgets-feedstock#61 there's something very strange. The value of CMAKE_ARGS appears to get set correctly in activation
(note: the second branch here is not taken, but I've pasted it because it shows the previously set value of CMAKE_ARGS)
but then when the build is invoked,
CMAKE_ARGSis emptySo instead of putting
-DPython_FIND_REGISTRY=...on a separate line as done in #99 and fixed up in #101, let's just update it in one go.Sorry for the thrashing, batch files are an apparently endless source of insanity that keeps uppercutting my jaw.