-
-
Notifications
You must be signed in to change notification settings - Fork 49
Remove [dz]gemmtr symbols from Windows build #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
21765e5
aee9e96
cb25dee
8f619e9
6999703
a074e29
8528a68
164aceb
ce538bc
d6f7c4e
88f220a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| From 025a7ea822ebff6a9d1fb1484c2de7acc8bc938e Mon Sep 17 00:00:00 2001 | ||
| From: Isabel Paredes <isabel.paredes@quantstack.net> | ||
| Date: Thu, 17 Jul 2025 18:59:06 +0200 | ||
| Subject: [PATCH] Remove dgemmtr and zgemmtr | ||
|
|
||
| --- | ||
| src/extra/blas/Rblas.def | 2 -- | ||
| src/modules/lapack/cmplx.f | 28 ++++++++++++++-------------- | ||
| src/modules/lapack/dlapack.f | 14 +++++++------- | ||
| 3 files changed, 21 insertions(+), 23 deletions(-) | ||
|
|
||
| diff --git a/src/extra/blas/Rblas.def b/src/extra/blas/Rblas.def | ||
| index b2eb43a82f..06ec1d8e1c 100644 | ||
| --- a/src/extra/blas/Rblas.def | ||
| +++ b/src/extra/blas/Rblas.def | ||
| @@ -7,7 +7,6 @@ EXPORTS | ||
| ddot_ | ||
| dgbmv_ | ||
| dgemm_ | ||
| - dgemmtr_ | ||
| dgemv_ | ||
| dger_ | ||
| dnrm2_ | ||
| @@ -48,7 +47,6 @@ EXPORTS | ||
| zdscal_ | ||
| zgbmv_ | ||
| zgemm_ | ||
| - zgemmtr_ | ||
| zgemv_ | ||
| zgerc_ | ||
| zgeru_ | ||
| diff --git a/src/modules/lapack/cmplx.f b/src/modules/lapack/cmplx.f | ||
| index 3bb15052ae..5d44e48f5d 100644 | ||
| --- a/src/modules/lapack/cmplx.f | ||
| +++ b/src/modules/lapack/cmplx.f | ||
| @@ -35308,7 +35308,7 @@ | ||
| EXTERNAL LSAME, IZAMAX | ||
| * .. | ||
| * .. External Subroutines .. | ||
| - EXTERNAL ZCOPY, ZDSCAL, ZGEMMTR, ZGEMV, ZLACGV, | ||
| + EXTERNAL ZCOPY, ZDSCAL, ZGEMV, ZLACGV, | ||
| $ ZSWAP | ||
| * .. | ||
| * .. Intrinsic Functions .. | ||
| @@ -35650,9 +35650,9 @@ | ||
| * | ||
| * (note that conjg(W) is actually stored) | ||
| * | ||
| - CALL ZGEMMTR( 'Upper', 'No transpose', 'Transpose', K, N-K, | ||
| - $ -CONE, A( 1, K+1 ), LDA, W( 1, KW+1 ), LDW, | ||
| - $ CONE, A( 1, 1 ), LDA ) | ||
| +* ZGEMMTR not implemented | ||
| + INFO = -1 | ||
| + RETURN | ||
| * | ||
| * Put U12 in standard form by partially undoing the interchanges | ||
| * in columns k+1:n looping backwards from k+1 to n | ||
| @@ -35997,9 +35997,9 @@ | ||
| * | ||
| * (note that conjg(W) is actually stored) | ||
| * | ||
| - CALL ZGEMMTR( 'Lower', 'No transpose', 'Transpose', N-K+1, | ||
| - $ K-1, -CONE, A( K, 1 ), LDA, W( K, 1 ), LDW, | ||
| - $ CONE, A( K, K ), LDA ) | ||
| +* ZGEMMTR not implemented | ||
| + INFO = -1 | ||
| + RETURN | ||
| * | ||
| * Put L21 in standard form by partially undoing the interchanges | ||
| * of rows in columns 1:k-1 looping backwards from k-1 to 1 | ||
| @@ -51658,7 +51658,7 @@ | ||
| EXTERNAL LSAME, IZAMAX | ||
| * .. | ||
| * .. External Subroutines .. | ||
| - EXTERNAL ZCOPY, ZGEMMTR, ZGEMV, ZSCAL, ZSWAP | ||
| + EXTERNAL ZCOPY, ZGEMV, ZSCAL, ZSWAP | ||
| * .. | ||
| * .. Intrinsic Functions .. | ||
| INTRINSIC ABS, DBLE, DIMAG, MAX, MIN, SQRT | ||
| @@ -51928,9 +51928,9 @@ | ||
| * | ||
| * A11 := A11 - U12*D*U12**T = A11 - U12*W**T | ||
| * | ||
| - CALL ZGEMMTR( 'Upper', 'No transpose', 'Transpose', K, N-K, | ||
| - $ -CONE, A( 1, K+1 ), LDA, W( 1, KW+1 ), LDW, | ||
| - $ CONE, A( 1, 1 ), LDA ) | ||
| +* ZGEMMTR not implemented | ||
| + INFO = -1 | ||
| + RETURN | ||
| * | ||
| * Put U12 in standard form by partially undoing the interchanges | ||
| * in columns k+1:n looping backwards from k+1 to n | ||
| @@ -52207,9 +52207,9 @@ | ||
| * | ||
| * A22 := A22 - L21*D*L21**T = A22 - L21*W**T | ||
| * | ||
| - CALL ZGEMMTR( 'Lower', 'No transpose', 'Transpose', N-K+1, | ||
| - $ K-1, -CONE, A( K, 1 ), LDA, W( K, 1 ), LDW, | ||
| - $ CONE, A( K, K ), LDA ) | ||
| +* ZGEMMTR not implemented | ||
| + INFO = -1 | ||
| + RETURN | ||
| * | ||
| * Put L21 in standard form by partially undoing the interchanges | ||
| * of rows in columns 1:k-1 looping backwards from k-1 to 1 | ||
| diff --git a/src/modules/lapack/dlapack.f b/src/modules/lapack/dlapack.f | ||
| index 284657d6b9..f0bd3e0867 100644 | ||
| --- a/src/modules/lapack/dlapack.f | ||
| +++ b/src/modules/lapack/dlapack.f | ||
| @@ -92173,7 +92173,7 @@ | ||
| EXTERNAL LSAME, IDAMAX | ||
| * .. | ||
| * .. External Subroutines .. | ||
| - EXTERNAL DCOPY, DGEMMTR, DGEMV, DSCAL, DSWAP | ||
| + EXTERNAL DCOPY, DGEMV, DSCAL, DSWAP | ||
| * .. | ||
| * .. Intrinsic Functions .. | ||
| INTRINSIC ABS, MAX, MIN, SQRT | ||
| @@ -92439,9 +92439,9 @@ | ||
| * | ||
| * A11 := A11 - U12*D*U12**T = A11 - U12*W**T | ||
| * | ||
| - CALL DGEMMTR( 'Upper', 'No transpose', 'Transpose', K, N-K, | ||
| - $ -ONE, A( 1, K+1 ), LDA, W( 1, KW+1 ), LDW, | ||
| - $ ONE, A( 1, 1 ), LDA ) | ||
| +* DGEMMTR not implemented | ||
| + INFO = -1 | ||
| + RETURN | ||
| * | ||
| * Put U12 in standard form by partially undoing the interchanges | ||
| * in columns k+1:n looping backwards from k+1 to n | ||
| @@ -92718,9 +92718,9 @@ | ||
| * | ||
| * A22 := A22 - L21*D*L21**T = A22 - L21*W**T | ||
| * | ||
| - CALL DGEMMTR( 'Lower', 'No transpose', 'Transpose', N-K+1, | ||
| - $ K-1, -ONE, A( K, 1 ), LDA, W( K, 1 ), LDW, | ||
| - $ ONE, A( K, K ), LDA ) | ||
| +* DGEMMTR not implemented | ||
| + INFO = -1 | ||
| + RETURN | ||
| * | ||
| * Put L21 in standard form by partially undoing the interchanges | ||
| * of rows in columns 1:k-1 looping backwards from k-1 to 1 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of changing this file, we should remove
cmplx.fanddlapack.ffrom Makefile.win as they are not needed when using an external blas library like we do.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the files seemed to cause too many undefined symbols errors, and removing more seemed to have broken the build 🫤
I updated the patch again to make minimal changes while still removing these two symbols. It seems to be working now.