Skip to content

Remove [dz]gemmtr symbols from Windows build#379

Closed
IsabelParedes wants to merge 11 commits into
conda-forge:mainfrom
IsabelParedes:win-gemmtr
Closed

Remove [dz]gemmtr symbols from Windows build#379
IsabelParedes wants to merge 11 commits into
conda-forge:mainfrom
IsabelParedes:win-gemmtr

Conversation

@IsabelParedes

@IsabelParedes IsabelParedes commented Jun 23, 2025

Copy link
Copy Markdown
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

The new patch removes the symbols zgemmtr and dgemmtr, and replaces the calls to these functions with the logic taken from version 4.4.3. This is only applicable to windows.

@conda-forge-admin

conda-forge-admin commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15852733586. Examine the logs at this URL for more detail.

@IsabelParedes

Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/15823380153. Examine the logs at this URL for more detail.

@IsabelParedes IsabelParedes changed the title Update patch to remove symbols Remove [dz]gemmtr symbols from Windows build Jun 23, 2025
@IsabelParedes IsabelParedes marked this pull request as ready for review June 23, 2025 12:46
@IsabelParedes IsabelParedes mentioned this pull request Jun 23, 2025
5 tasks
zgemv_
zgerc_
zgeru_
diff --git a/src/modules/lapack/cmplx.f b/src/modules/lapack/cmplx.f

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing this file, we should remove cmplx.f and dlapack.f from Makefile.win as they are not needed when using an external blas library like we do.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the files seemed to cause too many undefined symbols errors, and removing more seemed to have broken the build 🫤

I updated the patch again to make minimal changes while still removing these two symbols. It seems to be working now.

@IsabelParedes

Copy link
Copy Markdown
Member Author

I'm not sure why the windows build is getting stuck

x86_64-w64-mingw32-gcc   -shared  -o ../../../modules/x64/internet.dll 
internet.o libcurl.o sockconn.o Rhttpd.o Rsock.o sock.o dllversion.o 
internet.def -L../../../bin/x64 -lR -lRgraphapp -lwininet -lws2_32 
-L""/lib/x64 -lcurl

@isuruf

isuruf commented Jul 9, 2025

Copy link
Copy Markdown
Member

@conda-forge-admin rerender

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16159253380. Examine the logs at this URL for more detail.

@conda-forge-admin

conda-forge-admin commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16352112807. Examine the logs at this URL for more detail.

@IsabelParedes

Copy link
Copy Markdown
Member Author

@conda-forge-admin, please rerender

@isuruf

isuruf commented Aug 27, 2025

Copy link
Copy Markdown
Member

Fixed with #380

@isuruf isuruf closed this Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants