Skip to content

Fix artefact persistence on windows#395

Merged
h-vetinari merged 13 commits into
conda-forge:mainfrom
h-vetinari:artefact
Jul 4, 2025
Merged

Fix artefact persistence on windows#395
h-vetinari merged 13 commits into
conda-forge:mainfrom
h-vetinari:artefact

Conversation

@h-vetinari
Copy link
Copy Markdown
Member

In #391 we tried to add work-arounds for conda/infrastructure#1159; however, the artefact generation step is not yet functional on windows for GHA, see conda-forge/conda-smithy#2345.

After merging #393, things failed again on main, for win+CUDA and aarch+CUDA. This shows a second problem that can be quite annoying: the artefact generation is currently being run unconditionally, even when builds are cancelled. Over an hour after the job has been cancelled by timeout, the artefact generation (which is completely unnecessary in this case) has still not finished. Try to address this as well.

Actual fixes need to happen in smithy; this is both for developing the fix, as well as getting windows builds up.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Jul 3, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16060215048. Examine the logs at this URL for more detail.

@mgorny
Copy link
Copy Markdown
Contributor

mgorny commented Jul 3, 2025

Do I understand correctly that these changes will keep being overwritten on rerender?

@h-vetinari
Copy link
Copy Markdown
Member Author

Do I understand correctly that these changes will keep being overwritten on rerender?

See OP:

Actual fixes need to happen in smithy; this is both for developing the fix, as well as getting windows builds up.

:)

@h-vetinari h-vetinari marked this pull request as ready for review July 4, 2025 13:30
@h-vetinari h-vetinari merged commit 4e749d9 into conda-forge:main Jul 4, 2025
27 checks passed
@h-vetinari h-vetinari deleted the artefact branch July 4, 2025 13:30
@mgorny
Copy link
Copy Markdown
Contributor

mgorny commented Jul 4, 2025

Thanks for doing this!

@h-vetinari
Copy link
Copy Markdown
Member Author

h-vetinari commented Jul 5, 2025

OK, I finally have the artefact creation working - here it is for eb30820.

This is a bit of a special case not really considered by CFEP-3; the build has been fully produced by CI, with publicly visible logs, so the usual process of uploading to a private channel seems unnecessary? In any case, I did push them to my private channel, and have now run

DELEGATE=h-vetinari
PACKAGE_VERSION=2.7.1
for package in libtorch pytorch pytorch-gpu; do
  anaconda copy --from-label main --to-label main --to-owner conda-forge ${DELEGATE}/${package}/${PACKAGE_VERSION}
done

Please let me know if anyone disagrees with this approach going forward (while we're waiting for conda/infrastructure#1159 to be resolved) @conda-forge/core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants