Fix artefact persistence on windows#395
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16060215048. Examine the logs at this URL for more detail. |
|
Do I understand correctly that these changes will keep being overwritten on rerender? |
avoids `||`-condition, which is harder to make cross-platform
See OP:
:) |
|
Thanks for doing this! |
|
OK, I finally have the artefact creation working - here it is for eb30820. This is a bit of a special case not really considered by CFEP-3; the build has been fully produced by CI, with publicly visible logs, so the usual process of uploading to a private channel seems unnecessary? In any case, I did push them to my private channel, and have now run Please let me know if anyone disagrees with this approach going forward (while we're waiting for conda/infrastructure#1159 to be resolved) @conda-forge/core |
In #391 we tried to add work-arounds for conda/infrastructure#1159; however, the artefact generation step is not yet functional on windows for GHA, see conda-forge/conda-smithy#2345.
After merging #393, things failed again on main, for win+CUDA and aarch+CUDA. This shows a second problem that can be quite annoying: the artefact generation is currently being run unconditionally, even when builds are cancelled. Over an hour after the job has been cancelled by timeout, the artefact generation (which is completely unnecessary in this case) has still not finished. Try to address this as well.
Actual fixes need to happen in smithy; this is both for developing the fix, as well as getting windows builds up.