remove redundant setting of ARCHIVE_UNIQUE_ID in win artefact script#2346
Merged
Conversation
beckermr
approved these changes
Jul 3, 2025
Member
|
could use a news item? |
Member
Author
It's ultra-niche, so I think it'd be fine even without. I also haven't added a news-item yet, because I'm expecting several changes related to artefact persistence (on GHA) coming from conda-forge/pytorch-cpu-feedstock#395. I'm chasing down one last bug currently. Fine by me to wait here or merge this newslessly. I just opened a PR right away to not forget about this redundancy once I stumbled over it. |
Member
Author
|
There's now a news file in #2347 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that the following is fully redundant, and actually undoes the
%SHORT_CONFIG%logic, seeconda-smithy/conda_smithy/templates/create_conda_build_artifacts.bat.tmpl
Lines 33 to 40 in c9a3fbb