Skip to content

remove redundant setting of ARCHIVE_UNIQUE_ID in win artefact script#2346

Merged
beckermr merged 1 commit into
conda-forge:mainfrom
h-vetinari:artefact
Jul 3, 2025
Merged

remove redundant setting of ARCHIVE_UNIQUE_ID in win artefact script#2346
beckermr merged 1 commit into
conda-forge:mainfrom
h-vetinari:artefact

Conversation

@h-vetinari
Copy link
Copy Markdown
Member

Noticed that the following is fully redundant, and actually undoes the %SHORT_CONFIG% logic, see

rem Set a unique ID for the artifact(s), specialized for this particular job run
set ARTIFACT_UNIQUE_ID=%CI_RUN_ID%_%CONFIG%
if not "%ARTIFACT_UNIQUE_ID%" == "%ARTIFACT_UNIQUE_ID:~0,80%" (
set ARTIFACT_UNIQUE_ID=%CI_RUN_ID%_%SHORT_CONFIG%
)
rem Set a descriptive ID for the archive(s), specialized for this particular job run
set ARCHIVE_UNIQUE_ID=%CI_RUN_ID%_%CONFIG%

@h-vetinari h-vetinari requested a review from a team as a code owner July 3, 2025 01:43
@beckermr
Copy link
Copy Markdown
Member

beckermr commented Jul 3, 2025

could use a news item?

@h-vetinari
Copy link
Copy Markdown
Member Author

could use a news item?

It's ultra-niche, so I think it'd be fine even without. I also haven't added a news-item yet, because I'm expecting several changes related to artefact persistence (on GHA) coming from conda-forge/pytorch-cpu-feedstock#395. I'm chasing down one last bug currently.

Fine by me to wait here or merge this newslessly. I just opened a PR right away to not forget about this redundancy once I stumbled over it.

@beckermr beckermr merged commit 15b54dd into conda-forge:main Jul 3, 2025
2 checks passed
@h-vetinari h-vetinari deleted the artefact branch July 3, 2025 11:02
@h-vetinari
Copy link
Copy Markdown
Member Author

There's now a news file in #2347 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants