Skip to content

Conversation

@djhoese
Copy link
Contributor

@djhoese djhoese commented Aug 11, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@djhoese
Copy link
Contributor Author

djhoese commented Aug 11, 2025

Not sure why I didn't foresee this @snowman2 but it looks like the builds are failing on the same failure in the main pyproj repos. Not sure what the right move is here.

@snowman2
Copy link
Member

Not sure why I didn't foresee this @snowman2 but it looks like the builds are failing on the same failure in the main pyproj repos. Not sure what the right move is here.

In my opinion, the failing PROJ version should be marked as bad in conda-forge. Not sure if it is possible to add a pin here or if it has to happen in the conda-forge-pinning repo.

@xylar
Copy link
Contributor

xylar commented Aug 11, 2025

@snowman2, can you create an issue on https://github.com/conda-forge/proj.4-feedstock/issues stating which version(s) of proj need to be marked as broken and why? I can use that to make an admin request to get them marked as broken but it isn't clear enough to me what the issue is to make the request directly without first having an issue to point to.

There should be no need to update conda-forge-pinning unless we mark all 9.6.x versions as broken:
https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/migrations/proj96.yaml

@djhoese
Copy link
Contributor Author

djhoese commented Aug 11, 2025

@snowman2 what PROJ versions cause the issues? If I'm understanding the issue correctly it a small subset of projections or calculations that are incorrect, right? Maybe it would be enough for now to limit the version for this PRs build and then remove the limitation in the future depending on in the PROJ conda-forge package gets removed or the new PROJ version with fixes gets released.

@snowman2
Copy link
Member

9.6.2 is the version with the issue. Another alternative would be to apply this patch: OSGeo/PROJ#4526

@xylar
Copy link
Contributor

xylar commented Aug 11, 2025

@snowman2, I like the idea of patching, even if that means we mark builds 0 and 1 as broken.

@snowman2
Copy link
Member

Need to update pyproj tests: pyproj4/pyproj#1513

@xylar
Copy link
Contributor

xylar commented Aug 11, 2025

I opened a PR with the patch at conda-forge/proj.4-feedstock#163

@djhoese
Copy link
Contributor Author

djhoese commented Aug 11, 2025

@conda-forge-admin restart ci

@djhoese
Copy link
Contributor Author

djhoese commented Aug 11, 2025

Ok we're down to two failures which I think is an improvement and expected from @snowman2's previous comment:

FAILED test/test_transformer.py::test_transform_bounds__ignore_inf[ESRI:102036-input_bounds0-expected_bounds0] - AssertionError: 
Arrays are not almost equal to 0 decimals

Mismatched elements: 3 / 4 (75%)
Max absolute difference among violations: 50132027.16623251
Max relative difference among violations: inf
 ACTUAL: array([-5.e+07, -1.e+08,  5.e+07,  5.e+07])
 DESIRED: array([         0, -116576599,          0,          0])
FAILED test/test_transformer.py::test_transform_bounds__ignore_inf[ESRI:54026-input_bounds1-expected_bounds1] - AssertionError: 
Arrays are not almost equal to 0 decimals

Mismatched elements: 2 / 4 (50%)
Max absolute difference among violations: 88721834.46860172
Max relative difference among violations: inf
 ACTUAL: array([-9.e+07, -2.e+08,  9.e+07,  2.e+08])
 DESIRED: array([         0, -179545824,          0,  179545824])
=========== 2 failed, 1002 passed, 4 skipped, 185 warnings in 49.86s ===========

@djhoese
Copy link
Contributor Author

djhoese commented Aug 12, 2025

I'll work on an RC1 later today once github's current issues settle down.

@djhoese
Copy link
Contributor Author

djhoese commented Aug 12, 2025

@conda-forge-admin please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16923584465. Examine the logs at this URL for more detail.

@djhoese
Copy link
Contributor Author

djhoese commented Aug 14, 2025

Final release should be out now but I'm on mobile only for a while so I'll update this PR later. If the bot beats me to it we need to make sure the python limit change is included.

@djhoese
Copy link
Contributor Author

djhoese commented Aug 14, 2025

@conda-forge-admin please rerender

@djhoese djhoese marked this pull request as ready for review August 14, 2025 13:57
@djhoese djhoese requested review from xylar and zklaus as code owners August 14, 2025 13:57
@djhoese djhoese changed the title DEP: pyproj 3.7.2rc0 DEP: pyproj 3.7.2 Aug 14, 2025
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16967261264. Examine the logs at this URL for more detail.

@djhoese
Copy link
Contributor Author

djhoese commented Aug 14, 2025

Turns out I'm a maintainer of the pyproj upstream repository but not this feedstock. See #162

@djhoese djhoese added the automerge Merge the PR when CI passes label Aug 14, 2025
@conda-forge-admin conda-forge-admin merged commit 31af118 into conda-forge:main Aug 14, 2025
22 checks passed
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed
  • rerender called: passed

Thus the PR was passing, but could not be merged (error=API error in PUT to merge -- 'Merge already in progress').

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed
  • rerender called: passed

Thus the PR was passing and merged! Have a great day!

@djhoese djhoese deleted the 372_rc0 branch August 14, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants