-
-
Notifications
You must be signed in to change notification settings - Fork 15
DEP: pyproj 3.7.2 #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: pyproj 3.7.2 #160
Conversation
…nda-forge-pinning 2025.08.09.04.33.05
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Not sure why I didn't foresee this @snowman2 but it looks like the builds are failing on the same failure in the main pyproj repos. Not sure what the right move is here. |
In my opinion, the failing PROJ version should be marked as bad in conda-forge. Not sure if it is possible to add a pin here or if it has to happen in the conda-forge-pinning repo. |
|
@snowman2, can you create an issue on https://github.com/conda-forge/proj.4-feedstock/issues stating which version(s) of proj need to be marked as broken and why? I can use that to make an admin request to get them marked as broken but it isn't clear enough to me what the issue is to make the request directly without first having an issue to point to. There should be no need to update conda-forge-pinning unless we mark all 9.6.x versions as broken: |
|
@snowman2 what PROJ versions cause the issues? If I'm understanding the issue correctly it a small subset of projections or calculations that are incorrect, right? Maybe it would be enough for now to limit the version for this PRs build and then remove the limitation in the future depending on in the PROJ conda-forge package gets removed or the new PROJ version with fixes gets released. |
|
9.6.2 is the version with the issue. Another alternative would be to apply this patch: OSGeo/PROJ#4526 |
|
@snowman2, I like the idea of patching, even if that means we mark builds 0 and 1 as broken. |
|
Need to update pyproj tests: pyproj4/pyproj#1513 |
|
I opened a PR with the patch at conda-forge/proj.4-feedstock#163 |
|
@conda-forge-admin restart ci |
|
Ok we're down to two failures which I think is an improvement and expected from @snowman2's previous comment: |
|
I'll work on an RC1 later today once github's current issues settle down. |
|
@conda-forge-admin please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16923584465. Examine the logs at this URL for more detail. |
|
Final release should be out now but I'm on mobile only for a while so I'll update this PR later. If the bot beats me to it we need to make sure the python limit change is included. |
|
@conda-forge-admin please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16967261264. Examine the logs at this URL for more detail. |
|
Turns out I'm a maintainer of the pyproj upstream repository but not this feedstock. See #162 |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing, but could not be merged (error=API error in PUT to merge -- 'Merge already in progress'). |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)