-
-
Notifications
You must be signed in to change notification settings - Fork 25
Add patch to fix proj_trans_bounds() #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See OSGeo/PROJ#4526 This merge also organizes the other 2 patches for clarity
|
@snowman2, please take a look. |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16884438031. Examine the logs at this URL for more detail. |
snowman2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much appreciated. Didn't dig into the details, but approve of the concept.
|
@snowman2, no worries. I just wanted to make sure this was what you had in mind (in broad strokes). Let's see how it goes in pyproj... |
|
Is that normal to have in conda "patched" releases? A user using conda will have a different behaviour than one using the exact release. |
|
We're |
Yes, just like it is normal to have patched releases of things in distros like Debian. The intention is to upstream these patches, which appears to be the case for this one, which is simply waiting on a release.
IMO, it's a bit much to go back and x these builds out for this issue. |
@hobu, Yeah, I hope you're right. I'll only do it if it seems like downstream packages (notably pyproj) are picking up the older builds for some reason. |
See:
OSGeo/PROJ#4526
conda-forge/pyproj-feedstock#160 (comment)
This merge also organizes the other 2 patches for clarity
Checklist
conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)