Skip to content

openmp 12.0.1 (redux)#49

Merged
isuruf merged 6 commits into
conda-forge:masterfrom
h-vetinari:12.0.1
Jul 14, 2021
Merged

openmp 12.0.1 (redux)#49
isuruf merged 6 commits into
conda-forge:masterfrom
h-vetinari:12.0.1

Conversation

@h-vetinari

@h-vetinari h-vetinari commented Jul 10, 2021

Copy link
Copy Markdown
Member

Closes #48
Closes #47

I tried rebasing the failing patch, but it looks like it has become obsolete since llvm/llvm-project@7b52542

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member Author

Looking at https://github.com/llvm/llvm-project/blame/release/12.x/openmp/runtime/src/kmp.h, I have a suspicion that llvm/llvm-project@e0665a9 has broken the openmp windows build, because of improperly guarded __asm__.

Don't remember off the top of my head if #include <intrin.h> would help, but based on the logs, it's only looking for immintrin.h, and I don't think the guard is kicking in.

[...]
-- Looking for pthread.h
-- Looking for pthread.h - not found
-- Found Threads: TRUE  
-- Looking for immintrin.h
-- Looking for immintrin.h - found
-- Performing Test LIBOMP_HAVE_ATTRIBUTE_RTM
-- Performing Test LIBOMP_HAVE_ATTRIBUTE_RTM - Failed
[...]

@isuruf

isuruf commented Jul 13, 2021

Copy link
Copy Markdown
Member

We should just use clang-cl as the compiler for windows.

@isuruf isuruf merged commit f5997de into conda-forge:master Jul 14, 2021
@h-vetinari h-vetinari deleted the 12.0.1 branch July 14, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants