Skip to content

master: Add NumPy 1.13#78

Merged
patricksnape merged 3 commits intoconda-forge:masterfrom
jakirkham:use_np_113__master
Jun 18, 2017
Merged

master: Add NumPy 1.13#78
patricksnape merged 3 commits intoconda-forge:masterfrom
jakirkham:use_np_113__master

Conversation

@jakirkham
Copy link
Copy Markdown
Member

Re-render with conda-smithy 2.3.1 to add NumPy 1.13 to CI matrices.

@jakirkham
Copy link
Copy Markdown
Member Author

This may push us right up to the time limit on CircleCI. If so, I'd suggest we explicitly drop NumPy 1.11. In the end, this will be something we do throughout conda-forge anyways.

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@patricksnape
Copy link
Copy Markdown
Contributor

This now takes too long - can we drop 1.11?

@patricksnape
Copy link
Copy Markdown
Contributor

Ping @jakirkham do you think it's OK to drop 1.11?

@jakirkham
Copy link
Copy Markdown
Member Author

jakirkham commented Jun 15, 2017

That seems reasonable. My hands are just kind of full ATM as conda got upgraded in conda-forge and there are lots of things that broke as a consequence and need to be fixed and potentially pinned for the short term. Plus other work stuff.

Edit: I expect we will do the same thing throughout conda-forge soon. So this doesn't need to mergeable right now. We can put it off until that happens.

@patricksnape
Copy link
Copy Markdown
Contributor

I pushed removing 1.11 😄

@patricksnape
Copy link
Copy Markdown
Contributor

No idea what that CircleCI error is - something to do with linking protobuf?

@isuruf
Copy link
Copy Markdown
Member

isuruf commented Jun 15, 2017

It seems I've broken toolchain package. I'll revert the changes.

@jakirkham
Copy link
Copy Markdown
Member Author

No need. Have pulled the Linux version. The rest aren't released yet, but can pull them as well.

@patricksnape patricksnape merged commit fd8ea90 into conda-forge:master Jun 18, 2017
@jakirkham jakirkham deleted the use_np_113__master branch June 18, 2017 16:57
@jakirkham
Copy link
Copy Markdown
Member Author

FYI have worked up a proposal for CircleCI matrix support for conda-smithy in PR ( conda-forge/conda-smithy#532 ). Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants