Merged
Conversation
This was referenced Jun 18, 2017
Merged
jakirkham
commented
Jun 18, 2017
| {%- for dep, ver in case -%} | ||
| {%- if dep not in vars_used %} | ||
| -e {{ dep }}="${{ "{" }}{{ dep }}{{ "}" }}" \ | ||
| {%- do vars_used.append(dep) -%} |
Member
Author
There was a problem hiding this comment.
Would add this macro seems pretty slow. Really what we would want here is a way to get a Python set in Jinja, but did not see an obvious way to do that. If others have suggestions, would be interested to hear them.
This was referenced Jun 18, 2017
|
This would be very useful for Numpy builds +1 from me |
jakirkham
force-pushed
the
circle_2.0_matrix
branch
from
ba4d9f1 to
d98f3aa
Compare
Update the CircleCI configuration file, `.circleci/config.yml`, to specify the different jobs in the matrix and set the relevant environment variables for each build (if any). This results in no change for the skipped Linux build case. Also if there are no environment variables, that step is never added to the configuration file.
Changes the Docker build script to pass environment variables through from the CircleCI build so as to influence the `conda-build` invocation. This will make it unnecessary to build each matrix case sequentially inside the Docker container.
As the matrix has now been successfully moved outside of the Docker build script and into the CircleCI matrix, there is no need to have the build matrix within the Docker build script and as part of one build. Thus we cleanup this now no longer necessary content.
Member
Author
|
Any comments, @conda-forge/core? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #203
Closes conda-forge/patchelf-feedstock#12
Closes conda-forge/pyelftools-feedstock#15
Closes conda-forge/rank_filter-feedstock#27
Requires PR ( #530 ) be merged beforehand.Already done.Creates a proper build matrix on CircleCI 2.0 using the new Workflows. This allows us to have separate builds for Python and NumPy for instance. Though really this is not specific to those two. Instead applies to any environment variables that might be looped over and respected by
conda-build. This is no-op when Linux builds are skipped. Also it is nearly a no-op for Linux builds that don't require a matrix as it makes some minor changes (whitespace and comments).Some tests of this functionality can be seen in for the following cases:
Would note that CircleCI seems to like to add one status per build in the workflow. There is no difference if there is no matrix. However for any case with a non-trivial number of matrix cases, has an equal number of statuses for the PR. This isn't too bad for just Python (3 cases). However for Python and NumPy this can be quite a bit depending on what version are available. There doesn't appear to be any obvious way to change this.