Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/22230653968. Examine the logs at this URL for more detail. |
|
Running the tests single-threaded shows that the failing tests on osx-64 are likely due to a bug in the non-standard |
I tried to disable the contrib operators, but that triggered further test failures. Upstream has dropped support for |
|
|
For future reference: Both Windows and Linux CUDA builds currently fail in the Windows error: Linux error: The error seems to depend on the CUDA architectures. d5eaf74 , which had a reduced list of architectures (Windows: I'll try to bisect the architectures. |
|
I think this is coming together now, @conda-forge/onnxruntime . Notable changes:
Things to do (preferably in follow-up PRs):
Would be great to get a second pair of eyes on this! |
There was a problem hiding this comment.
Things to do (preferably in follow-up PRs):
I agree that good engineering practices are to keep changes separate, but I need to ask you to combine changes here as much as feasible. Not least with the -vec/-novec split, this feedstock has a huge impact on the limited CI resources we have for this, so single-purpose PRs are not a good thing here.
(and in the same vein: development of a PR should run with a restricted set of builds, e.g. only for one python version; until everything for that one version is green, then ask for review, and once everything is good to go, do a final fan-out to all the versions before merging)
For example, #168 is missing from your list, and should be folded into this or an upcoming PR (though with a cleaned up history without the skips & rerenders).
It's OK to merge this one if it's ready, but IMO everything on your list (with perhaps the exception of free threading) + CMake should go into a single PR.
recipe/patches/0002-avoid-conflicting-with-onnxruntime.dll-in-system32.patch
Show resolved
Hide resolved
|
Thanks for your feedback @h-vetinari ! I now did the following (this PR is back to being a WIP):
I'll try:
|
|
Thanks!
It's not so much a budget question, as it is a question of a resource bottleneck that blocks anyone else from using the server for ~a day if you do a full build out. We're also working on improving this situation, but it'll still take a little while. Big CI always costs something somewhere... |
|
Python 3.14 seems partially broken on PyPI as well: microsoft/onnxruntime#27392 I'll remove it again from this PR for the time being 😞 |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/22231499544. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/22392316127. Examine the logs at this URL for more detail. |
|
Status update: The current build errors on Windows seem unrelated. I tried moving over to Pixi, but that gave me an actual error when building. Let's see if the Windows/micromamba error goes away in a couple of days... |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/22403647116. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/22531959828. Examine the logs at this URL for more detail. |
|
|
hmaarrfk
left a comment
There was a problem hiding this comment.
Im ok with dropping osx-64. But I would like to rebase the patches to have fewer than 38
ae2b675 to
289015f
Compare
|
I squashed the commits and enabled LTO, but I haven't faned out to the full matrix yet. I'll wait at least until tomorrow with that to see if anybody else has feedback. |
h-vetinari
left a comment
There was a problem hiding this comment.
Nicely done!
(the 70-architecture is included in 12.9 builds, but excluded on 13.0 due to build failures)
it's not really a failure, CUDA 13.0 has simply dropped support for anything below sm_75.
|
2 approvals. i think you can start to build the final version |
|
OK, so the build here is basically finished now; the matrix is getting pretty hard to build out, so if moving to the stable ABI is feasible, we should try that (independently of this PR, which can be merged as-is). As another comment: it's good to keep a clean commit history, but 289015f does too much, especially for its very unassuming commit message. In general, please keep changes in |
I'm actually already exploring this. Upstream does not use Python's stable ABI3 (is that what you are referring to?). I'll give it a spin, but would be surprised if it Just Works. Another option I'm looking into is building the dynamic library first, and then building only the Python bindings with dynamic linking in follow-up steps.
Will keep that in mind. Thanks! |
|
Update on the stable API: onnxruntime uses pybind11 and pybind11 does not support ABI3: pybind/pybind11#5905 (comment) |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.Closes: #167
Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/21737426351 - please use this URL for debugging.