Add cmake files in onnxruntime-cpp#168
Add cmake files in onnxruntime-cpp#168diegoferigo-rai wants to merge 26 commits intoconda-forge:mainfrom
onnxruntime-cpp#168Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/22118185634. Examine the logs at this URL for more detail. |
|
@diegoferigo-rai if you are still iterating on this and you are not running the build locally, can you temporary skip most of the builds leaving just a combination? Only macOS builds are running now, but macOS runners are a bit scarce, so it would be ideal to run the full macOS jobs matrix only if necessary. |
I wasn't sure how to configure the workflow to skip the non-Linux jobs temporarily. Did you mean I should modify the CI configuration file directly, or is there another method? In any case, I've finished iterating on the PR and the changes should be good to go. |
|
Ok! The next step is to trigger the build on the cirun server, but I think it is a bit congested at the moment due to PyTorch 2.10 + CUDA 13.0 + Python 3.14, I would wait the go from @h-vetinari for doing that. |
|
Thank you all for the support. This isn't urgent, so it can wait a couple more days. I'm also looking forward to having CUDA 13 support here! |
|
Just to clarify in case anyone reads here, the fallback until CMake config files are actually installed is to use |
…6.02.01.23.20.06 Other tools: - conda-build 25.11.1 - rattler-build 0.55.1 - rattler-build-conda-compat 1.4.10
|
@h-vetinari any update on this PR? Mind triggering CI again? |
|
Thanks @h-vetinari, hopefully fixed in 6c897e4. I missed a step on windows. |
…6.02.05.22.05.09 Other tools: - conda-build 26.1.0 - rattler-build 0.55.1 - rattler-build-conda-compat 1.4.10
|
It seems that there are problems downloading this zip file on windows. The URL looks valid though. |
|
Apologies for the ping, @h-vetinari. I'm really hoping to have the exported targets in v1.24 (PR #169). After checking the logs, it seems that the download failure occurred during the initial bat script configuration, before the lines I added were executed. Could you please trigger a re-run? Thanks! |
|
I restarted one of the failed jobs now. :) |
|
Now the build fails later on Windows, when it runs I do not have a Windows machine, and manually iterating on CI here is quite painful. If no one is available to take a look at the Windows side, I will update this PR to target only linux and macos for now. Does that sound reasonable to you @h-vetinari? Windows support could be implemented in another PR. |
No, that does not sound acceptable. I'll switch this back to azure for you so you can debug on your merry way, but we don't simply drop a platform because we can't get something to work (especially because this looks like a pretty trivial problem about the naming of folders and/or targets). I agree that debugging in CI is not fun, but that's the way it is, unless you want to organise yourself a suitable machine or VM. |
…6.02.09.23.12.11 Other tools: - conda-build 26.1.0 - rattler-build 0.55.1 - rattler-build-conda-compat 1.4.10
|
Thanks for switching the CI, that will make iterating much easier! I'm happy to look into the Windows side, though my initial suggestion was based on the idea that having a feature available for a subset of platforms is often better for the community than having none at all. I worry that requiring contributors to set up complex local environments (like VMs) can create a high barrier to entry and discourage future contributions, which I'm sure is something we'd all like to avoid. That said, I appreciate your support, and I'm more than happy to finalize it for all platforms now that the overhead is lower for everyone and I can iterate my way on CI. |
|
CI is now passing also on windows! @h-vetinari let me know if there is anything else I can help with. |
|
Friendly ping @h-vetinari. This is ready to go, perhaps @cbourjau or another maintainer could help with the final steps to get this merged? |
|
@conda-forge-admin, please rerender |
|
Closed via #169 |
I'm afraid that will be a longer wait 😬 ! We currently don't build CUDA versions on linux-aarch64: onnxruntime-feedstock/recipe/meta.yaml Line 40 in 3c0038c |
|
Ah, got it, thanks for the info! I missed that skip, which explains why there are no packages. What's the limitation at the moment? |
|
We ran into build errors in the recent past, but I'm afraid I forgot to retry it on the latest release. Would you like to give it a spin? If it works, we can include it in 1.24.3, which seems to be imminent upstream. |
|
Worth checking #172 🤞 |

Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)