Skip to content

TEST: 1.23.x + blas variants#273

Closed
h-vetinari wants to merge 2 commits into
conda-forge:numpy123from
h-vetinari:1.23_blas_vars
Closed

TEST: 1.23.x + blas variants#273
h-vetinari wants to merge 2 commits into
conda-forge:numpy123from
h-vetinari:1.23_blas_vars

Conversation

@h-vetinari

Copy link
Copy Markdown
Member

Continuing the analysis from #252, #237, #227 & #196. Should not be merged for the same reasons as #227.

@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member Author

Update for numpy 1.23

After being all green for 1.22.3, we're still all green for 1.23.0 🥳 (with some small caveats below)

Notable

Restrictions

  • ppc64le and pypy-on-aarch only run tests with label='fast', not the full test suite
  • the following test skips:
# https://github.com/numpy/numpy/issues/15243
{% set tests_to_skip = tests_to_skip + " or test_loss_of_precision[complex256]" %}  # [ppc64le]
# Sometimes crashes on travis (needs too much memory); since 1.22.4 it fails for pypy
{% set tests_to_skip = tests_to_skip + " or test_large_archive" %}                  # [(CI == "travis") or ((python_impl == "pypy") and linux)]
# there are some tests that cannot really work in emulation, see e.g. numpy/numpy#20445
{% set tests_to_skip = tests_to_skip + " or Test_ARM_Features" %}                   # [build_platform != target_platform]
# test_new_policy reruns part of test suite; including a CPU feature test that fails in emulation
{% set tests_to_skip = tests_to_skip + " or test_new_policy" %}                     # [build_platform != target_platform]
# flaky refcount-based test; already skipped upstream for win+py39
{% set tests_to_skip = tests_to_skip + " or test_partial_iteration_cleanup" %}      # [osx]

Details

variant before after
linux + ppc (on azure) test failures due to emulation problems same (see #274 & here)
linux + ppc (on travis) fine (with 2 test skips) same

lib before after updated
version
updated
build
numpy 1.22.3 1.23.0 X
libblas 3.9.0-14 3.9.0-15 X
blis 0.9.0-0 0.9.0-0
openblas 0.3.20-pthreads-0 0.3.20-pthreads-0
mkl 2022.0.1-803 2022.1.0-915 X
netlib 3.9.0-5 3.9.0-5
pypy 7.3.9-2 7.3.9-2
qemu-user-static 6.1.0-8 7.0.0-7 X

variant accelerate blis mkl netlib openblas sum*
linux / x86 ✔️ ✔️ ✔️ ✔️ -
linux / aarch ✔️ ✔️ -
linux / ppc64le ✔️ ✔️ -
osx / arm ✔️ ✔️ ✔️ -
osx / x86 ✔️ ✔️ ✔️ ✔️ ✔️ -
win / x86 ✔️ ✔️ ✔️ ✔️ -
sum* - - - - - -

* sum of Failures (out of a total of 94 CI combinations being tested)

Build logs:
Azure
Travis

@rgommers

Copy link
Copy Markdown
Contributor

Looks great!

@h-vetinari h-vetinari changed the base branch from main to numpy123 January 27, 2023 05:58
@conda-forge-webservices

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member Author

Update for numpy 1.23.5

After being all green for 1.23.0, we're still all green for 1.23.5 🥳 (with some small caveats below)

Notable

Restrictions

  • ppc64le and pypy-on-aarch only run tests with label='fast', not the full test suite
  • the following test skips:
# https://github.com/numpy/numpy/issues/15243
{% set tests_to_skip = tests_to_skip + " or test_loss_of_precision[complex256]" %}  # [ppc64le]
# Sometimes crashes on travis (needs too much memory); since 1.22.4 it fails for pypy
{% set tests_to_skip = tests_to_skip + " or test_large_archive" %}                  # [(CI == "travis") or ((python_impl == "pypy") and linux)]
# there are some tests that cannot really work in emulation, see e.g. numpy/numpy#20445
{% set tests_to_skip = tests_to_skip + " or Test_ARM_Features" %}                   # [build_platform != target_platform]
# test_new_policy reruns part of test suite; including a CPU feature test that fails in emulation
{% set tests_to_skip = tests_to_skip + " or test_new_policy" %}                     # [build_platform != target_platform]
# flaky refcount-based test; already skipped upstream for win+py39
{% set tests_to_skip = tests_to_skip + " or test_partial_iteration_cleanup" %}      # [osx]

Details

variant before after
linux + ppc (on azure) test failures due to emulation problems looks like #274 is now working 🥳
linux + ppc (on travis) fine (with 2 test skips) same

lib before after updated
version
updated
build
numpy 1.23.0 1.23.5 X
libblas 3.9.0-15 3.9.0-16 X
blis 0.9.0-0 0.9.0-0
openblas 0.3.20-pthreads-0 0.3.21-pthreads-3 X
mkl 2022.1.0-915 2022.1.0-915
netlib 3.9.0-5 3.9.0-5
pypy 7.3.9-2 7.3.9-7 X
qemu-user-static 7.0.0-7 7.2.0-1 X

variant accelerate blis mkl netlib openblas sum*
linux / x86 ✔️ ✔️ ✔️ ✔️ -
linux / aarch ✔️ ✔️ -
linux / ppc64le ✔️ ✔️ -
osx / arm ✔️ ✔️ ✔️ -
osx / x86 ✔️ ✔️ ✔️ ✔️ ✔️ -
win / x86 ✔️ ✔️ ✔️ ✔️ -
sum* - - - - - -

* sum of Failures (out of a total of 114 CI combinations being tested)

Build logs:
Azure
Travis

@h-vetinari

Copy link
Copy Markdown
Member Author

With the appearance of 1.25, I'm closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants