Skip to content

Feat/fix swing rebuild cuda118 0 1 hf015d0#24

Open
mikemhenry wants to merge 4 commits into
conda-forge:mainfrom
mikemhenry:feat/fix_swing_rebuild_cuda118-0-1_hf015d0
Open

Feat/fix swing rebuild cuda118 0 1 hf015d0#24
mikemhenry wants to merge 4 commits into
conda-forge:mainfrom
mikemhenry:feat/fix_swing_rebuild_cuda118-0-1_hf015d0

Conversation

@mikemhenry

@mikemhenry mikemhenry commented Dec 8, 2023

Copy link
Copy Markdown

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@mikemhenry mikemhenry requested a review from jlmaccal as a code owner December 8, 2023 18:51
@conda-forge-webservices

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham

jakirkham commented Dec 8, 2023

Copy link
Copy Markdown
Member

Thanks Mike! 🙏

Seeing this in one CI failure

  Traceback (most recent call last):
    File "/home/conda/feedstock_root/build_artifacts/meld_1702062541040/work/meld/comm.py", line 421, in _get_mpi_comm_world
      from mpi4py import MPI  # type: ignore
      ^^^^^^^^^^^^^^^^^^^^^^
  ModuleNotFoundError: No module named 'mpi4py'

It looks like mpi4py is declared in test/requires. Should we move it to requirements/run?

test:
requires:
- mpich
- mpi4py

Edit: The error before it is interesting too

  ValueError: mutable default <class 'openmm.unit.quantity.Quantity'> for field pressure is not allowed: use default_factory

Edit 2: Looks similar to this user error ( maccallumlab/meld#133 (comment) ). Guessing it has something to do with this line upstream

Edit 3: Filed upstream issue ( maccallumlab/meld#160 )

Edit 4: Looks like this was fixed in PR ( maccallumlab/meld#157 )

@mikemhenry

Copy link
Copy Markdown
Author

Thanks! I will add another patch so we can fix this while we wait for upstream to cut a release

@jakirkham

Copy link
Copy Markdown
Member

@conda-forge-admin , please re-render

@mikemhenry

Copy link
Copy Markdown
Author

Oh wow a blast from the past -- did upstream make a release or do we need a patch still?

@jakirkham

Copy link
Copy Markdown
Member

Hey Mike 👋

AFAICT we still need the patch

Was going back through CUDA 11.8 PRs as we are planning to drop CUDA 11.2 support soon: conda-forge/conda-forge-pinning-feedstock#5339

Trying to see if we can get PRs (like this one) across the line. So that there will be a working CUDA 11 build after

@mikemhenry

Copy link
Copy Markdown
Author

Thanks! I will add another patch so we can fix this while we wait for upstream to cut a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants