llvmdev 17.0.1#238
Merged
Merged
Conversation
…nda-forge-pinning 2023.07.16.20.15.24
Clarification following llvm/llvm-project@c6bd873
0002-Always-copy-on-windows.patch became obsolete and can now be handled through an option, see llvm/llvm-project@5c602c4
17.0.0.dev0
…nda-forge-pinning 2023.07.27.11.28.36
llvmdev 17.0.0.rc1
automerged PR by conda-forge/automerge-action
automerged PR by conda-forge/automerge-action
…nda-forge-pinning 2023.09.19.07.30.00
h-vetinari
requested review from
JohanMabille,
SylvainCorlay,
inducer,
isuruf,
jakirkham,
mingwandroid,
timsnyder and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
commented
Sep 19, 2023
h-vetinari
left a comment
h-vetinari
left a comment
Member
Author
There was a problem hiding this comment.
Some context for the changes.
| -DCMAKE_BUILD_TYPE="Release" ^ | ||
| -DCMAKE_PREFIX_PATH=%LIBRARY_PREFIX% ^ | ||
| -DCMAKE_INSTALL_PREFIX:PATH=%LIBRARY_PREFIX% ^ | ||
| -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreadedDLL ^ |
| -DLLVM_INCLUDE_TESTS=ON ^ | ||
| -DLLVM_INCLUDE_UTILS=ON ^ | ||
| -DLLVM_INSTALL_UTILS=ON ^ | ||
| -DLLVM_USE_SYMLINKS=OFF ^ |
This was referenced Sep 19, 2023
.0 got pulled because of the suffix issue, see https://discourse.llvm.org/t/llvm-17-0-0-tagged-but-with-a-mistake/73545
Member
Author
|
Something is off with the GH/Azure webhooks; I've pushed an update to https://github.com/h-vetinari/llvmdev-feedstock/tree/17, but it's not being picked up. 😑 |
h-vetinari
force-pushed
the
17
branch
2 times, most recently
from
06f004b to
197437d
Compare
Member
Author
|
OK, this took a few final fits and starts, but is now ready for review @conda-forge/llvmdev PTAL 🙏 |
Member
Author
|
Gentle ping @conda-forge/llvmdev |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a simple bump from what's already in the
rc-channel.Closes #227, see da3c0eb
Closes #239