add entry-point for llvm-lit#210
Conversation
h-vetinari
requested review from
JohanMabille,
SylvainCorlay,
inducer,
isuruf,
jakirkham,
mingwandroid,
timsnyder and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Did you check the setup.py file? |
Nope (now I did), because I didn't doubt that the choice of It seems that LLVM itself is inconsistent (I might raise an issue if we think it's worth it), but in the meantime I think it'd be better to have both entry points, no? |
|
Yes, but please make your comment better. |
Upstream is inconsistent; lit's setup.py uses "lit", see https://github.com/llvm/llvm-project/blob/llvmorg-16.0.2/llvm/utils/lit/setup.py#L47 whereas the LLVM's CMake files use "llvm-lit", see https://github.com/llvm/llvm-project/blame/llvmorg-16.0.2/llvm/cmake/modules/AddLLVM.cmake#L1851
|
Can you check if the comment is OK now? If so, I'm also planning to backport this to 15.x. |
isuruf
left a comment
isuruf
left a comment
There was a problem hiding this comment.
Looks good, but tests seem to time out now
This happens somewhat regularly when the osx agent is slow. I doubt that an additional entry point will lengthen the build in any substantial way. Thanks for restarting! |
2 participants
By default, LLVM's CMake files will look for
llvm-lit. Add this entry-point to make life easier for consuming feedstocks (i.e. without manually having to setLLVM_EXTERNAL_LIT).The existing
litentrypoint here was set in #67, not sure what rationale went into the naming at the time (matches pip import, though no discussion in the PR); in any case I think it would be fine to keep both.PTAL @isuruf
CC @hmaarrfk