[14.x] Fix dependency on windows image; llvm-lit entry point; libxml2#199
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
5b96e02 to
54e0837
Compare
|
@isuruf, any preference for how to fix this? I avoided I'd know how to do it with sed, but not what's currently going wrong with powershell. |
|
It's fine to use |
|
@conda-forge-admin, please rerender |
84145b1 to
2d10f45
Compare
This is the entry point that LLVM embeds into its cmake files as well, see https://github.com/llvm/llvm-project/blame/llvmorg-14.0.6/llvm/cmake/modules/AddLLVM.cmake#L1757
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
…nda-forge-pinning 2023.05.17.11.43.25
|
Here's the file (after sed-replacement): Contents of
|
|
Isn't this PR doing multiple things? What's the reason for going away from the supposed "standard code practices" in this case? |
I'm trying to avoid doing too many rebuilds, which cause lots of artefact & download churn. All these changes are well-understood and the diff is <100 lines, so bundling them is IMO not an issue. If you prefer me to split, I can do it. For me, it's different from boost in terms of scope (3 small things vs. complete-recipe-rewrite), so the fact that each PR actually builds artefacts tips the balance towards bundling here. |
Fixes #175
Fixes conda-forge/clangdev-feedstock#202
Also backport #210 & #222
Closes #222