Skip to content

lld 12.0.1 (redux)#27

Merged
github-actions[bot] merged 8 commits into
conda-forge:masterfrom
h-vetinari:12.0.1
Jul 14, 2021
Merged

lld 12.0.1 (redux)#27
github-actions[bot] merged 8 commits into
conda-forge:masterfrom
h-vetinari:12.0.1

Conversation

@h-vetinari

@h-vetinari h-vetinari commented Jul 13, 2021

Copy link
Copy Markdown
Member

Closes #26
Closes #25

Following @isuruf's suggestion.

@h-vetinari h-vetinari requested a review from isuruf as a code owner July 13, 2021 23:03
@conda-forge-linter

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member Author

Haven't had time to figure out what's happening with all these CMake paths, and why the relevant include-directory is not being picked up despite the call being there in lld/CMakeLists.txt.

@h-vetinari

Copy link
Copy Markdown
Member Author

@isuruf @xhochy
Haven't ever built LLVM before, so I'm a bit stuck here once the trivial adaptations don't work.

I find the include_directories(${LLVM_MAIN_SRC_DIR}/../libunwind/include) really weird, because it seems to be going out one folder level too far, and indeed, the windows build shows why this doesn't work:
-ID:\bld\llvm-package_1625847118277\work\..\libunwind\include

I'm have an exploratory patch for this now, but not sure if that's the right approach. In the same vein, I'm not sure what the purpose of the previous patch was - pointers appreciated.

@h-vetinari

Copy link
Copy Markdown
Member Author

@isuruf, this should be ready for review. Last run was green, I just rebased to clean up my derps a bit and remove the overzealous logging again.

@isuruf isuruf added the automerge Merge the PR when CI passes label Jul 14, 2021
@github-actions github-actions Bot merged commit 7d15808 into conda-forge:master Jul 14, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • drone: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari h-vetinari deleted the 12.0.1 branch July 14, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants