Also pin and version by libcxx#9
Merged
Merged
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This was referenced Aug 26, 2024
Merged
This was referenced Aug 27, 2024
This was referenced Mar 20, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it turns out, when trying to rebuild older libcxx (say 16 while newest is 18), the
downstream:test forlibcxx-testingpulls in the newest libcxx, not the one currently being built. To make it possible to choose which libcxx-testing we run against, add a libcxx constraint here.I'm starting with 16; obviously I'll have to build this for 17, 18 as well. If necessary, we can then also branch off here if we ever need to rebuild something for libcxx 16 again. However, to not turn this into a bootstrapping nightmare (e.g. new libcxx needing a libcxx-testing that pins a version that doesn't exist yet), I'll re-add an escape-hatch where the main branch of libcxx will not pin the patch version of libcxx-testing, and get a libcxx-testing without a libcxx constraint.