Another attempt at 3.12.1 bump#85
Conversation
…onda-forge-pinning 2025.01.08.04.32.23
…nda-forge-pinning 2025.05.27.09.45.32
Signed-off-by: Michał Górny <mgorny@quansight.com>
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19148087224. Examine the logs at this URL for more detail. |
|
Hmm, maybe we should configure it to use |
mgorny
force-pushed
the
3.12.1_hf89c5c
branch
2 times, most recently
from
881e12b to
2efd54e
Compare
Signed-off-by: Michał Górny <mgorny@quansight.com>
…5.11.06.19.20.54 Other tools: - conda-build 25.9.0 - rattler-build 0.49.0 - rattler-build-conda-compat 1.4.9
mgorny
force-pushed
the
3.12.1_hf89c5c
branch
from
24d0323 to
0490969
Compare
|
@isuruf, thanks! Could you tell me what you think of the MSVC patch? I'm thinking this is something I could upstream. |
|
Looks good. That's basically what https://github.com/OpenMathLib/OpenBLAS/blob/aa7e9abf52d1bf5429062e0f6d3d497d19884443/lapack-netlib/LAPACKE/include/lapacke_config.h#L88-L95 does right? |
|
Heh, yes. Why didn't I think somebody must have solved it already… |
|
Reference-LAPACK/lapack#1164 now. If that works out, we may also want to upstream the DLL patch — but I don't really know the details for it. |
h-vetinari
left a comment
h-vetinari
left a comment
There was a problem hiding this comment.
Just noticed some issues here that will be problematic. I'm going to send a rebuild and mark the existing builds; they're only in lapack_rc with no downloads anyway.
| {% set version = "3.11.0" %} | ||
| {% set version = "3.12.1" %} | ||
| # if build_num is reset to 0 (for new version), update increment for blas_minor below | ||
| {% set build_num = 5 %} |
There was a problem hiding this comment.
Pity that this didn't reset the build number
There was a problem hiding this comment.
Uh, sorry about that.
| # for builds across lapack-versions within the same blas_major | ||
| {% set blas_minor = build_num + 200 %} |
There was a problem hiding this comment.
And disregarded this instruction.
|
Pushed fix-up 2075aec |
5 participants
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Basically a rerun of #78 since the logs are gone, with an extra patch and a rerender.