Skip to content

ensure versions for output 'blas' don't overlap#46

Merged
isuruf merged 5 commits into
conda-forge:masterfrom
h-vetinari:master
Jan 5, 2021
Merged

ensure versions for output 'blas' don't overlap#46
isuruf merged 5 commits into
conda-forge:masterfrom
h-vetinari:master

Conversation

@h-vetinari

@h-vetinari h-vetinari commented Jan 2, 2021

Copy link
Copy Markdown
Member

Sister PR for fixing the same issue as conda-forge/blas-feedstock#60.

@conda-forge-linter

conda-forge-linter commented Jan 2, 2021

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libblas' output doesn't have any tests.
  • It looks like the 'libcblas' output doesn't have any tests.
  • It looks like the 'liblapack' output doesn't have any tests.
  • It looks like the 'liblapacke' output doesn't have any tests.
  • It looks like the 'blas-devel' output doesn't have any tests.
  • It looks like the 'lapack' output doesn't have any tests.

@beckermr

beckermr commented Jan 2, 2021

Copy link
Copy Markdown
Member

@conda-forge-admin rerender

@conda-forge-linter

conda-forge-linter commented Jan 2, 2021

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter

conda-forge-linter commented Jan 2, 2021

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • It looks like the 'libblas' output doesn't have any tests.
  • It looks like the 'libcblas' output doesn't have any tests.
  • It looks like the 'liblapack' output doesn't have any tests.
  • It looks like the 'liblapacke' output doesn't have any tests.
  • It looks like the 'blas-devel' output doesn't have any tests.
  • It looks like the 'lapack' output doesn't have any tests.

@h-vetinari

h-vetinari commented Jan 2, 2021

Copy link
Copy Markdown
Member Author

As stated here for blas, I'd be willing to become a maintainer for this feedstock.

@h-vetinari

h-vetinari commented Jan 5, 2021

Copy link
Copy Markdown
Member Author

@isuruf, WDYT about this one?

@isuruf

isuruf commented Jan 5, 2021

Copy link
Copy Markdown
Member

Looks good to me. I'll merge it the next time that there's an update

@isuruf isuruf merged commit c5040b8 into conda-forge:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beckermr beckermr Awaiting requested review from beckermr
@isuruf isuruf Awaiting requested review from isuruf
@jakirkham jakirkham Awaiting requested review from jakirkham

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@h-vetinari @conda-forge-linter @beckermr @isuruf