ensure versions for output 'blas' don't overlap#60
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
After #59, On the other hand, |
| @@ -2,6 +2,10 @@ | |||
| {% set build_num = 5 %} | |||
There was a problem hiding this comment.
Let's change this to 22 and make a comment that it should not be reset to 0
There was a problem hiding this comment.
It's not by a big margin, but I don't think that's a better solution, for two reasons:
- new lapack versions should IMO reset the build number (aside from being confusing for CF-regulars, the GH PR template invites to), and there's really two different constructs being versioned here (lapack & CF-blas-arch), which don't have to have the same
build_num - in case there's ever a need to create a branch for rebuilding for an older lapack-version, it would be very intransparent what the right
build_numshould be
There was a problem hiding this comment.
I don't really agree with 1., but 2 is good enough. Can you add a comment above that if it is reset, then blas_minor offset needs to be updated.
There was a problem hiding this comment.
As a matter of fact, what do you think about creating a 3.8 branch here and we do one more build that has a consistent build number & corresponding blas-version? Because currently, there's a bit of an eclectic mix with blas builds for 3.9 but with low numbers
There was a problem hiding this comment.
It'll still be hard to follow as well. netlib builds are done with a different build number as well and I don't think we'll be able to keep the build numbers in sync for different blas implementations and IMO that's okay.
There was a problem hiding this comment.
Sure, but the netlib ones don't have an associated blas package.
There was a problem hiding this comment.
Nevermind, they do. OK, I'll drop the argument for a 3.8 rebuild, thanks for the exchange
There was a problem hiding this comment.
Thanks for the discussion. I really appreciate your work on better BLAS support on conda-forge.
| - if not exist %LIBRARY_BIN%/liblapacke.dll exit 1 # [win] | ||
|
|
||
| - name: blas-devel | ||
| # uses lapack {{ version }}, not {{ blas_major }} |
There was a problem hiding this comment.
I was double-checking this, because it's not immediately clear from the recipe what's happening here. To be honest, I was surprised that blas-devel is using a different versioning scheme than blas, but whether intentional or not, it probably can't be fixed or changed until blas_major overtakes the lapack version. In the meantime, I thought it's better to leave a comment.
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
The versions strings for output
blaswere colliding with the ones that had been produced for lapack 3.8.0 (at least). Disambiguate by bumping the number that goes into those version strings.