Skip to content

Conversation

@bjlittle
Copy link
Contributor

@bjlittle bjlittle commented Oct 22, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bjlittle
Copy link
Contributor Author

@conda-forge-admin, please rerender

@bjlittle
Copy link
Contributor Author

@ocefpaf I don't know the best practice here... but in your opinion is it okay to make iris a noarch package without bumping the version (only bumping the build number).

Note, we're due to release iris 3.2 most likely in January 2022, so should we wait until then to do this instead?

@bjlittle
Copy link
Contributor Author

@conda-forge-admin, please rerender

@bjlittle
Copy link
Contributor Author

@jamesp Are you okay being added as an iris package maintainer

@ocefpaf
Copy link
Member

ocefpaf commented Nov 22, 2021

@ocefpaf I don't know the best practice here... but in your opinion is it okay to make iris a noarch package without bumping the version (only bumping the build number).

It is fine to just bump the build number. No need for a new version b/c this is 100% related to the build and not the version.

@jamesp Are you okay being added as an iris package maintainer

We cannot merge this unless @jamesp gives an OK.

@jamesp
Copy link

jamesp commented Nov 23, 2021

@ocefpaf @bjlittle yes good with me, thanks!

@ocefpaf
Copy link
Member

ocefpaf commented Nov 23, 2021

Closing and reopening to toggle the CIs.

@ocefpaf ocefpaf closed this Nov 23, 2021
@ocefpaf ocefpaf reopened this Nov 23, 2021
@ocefpaf
Copy link
Member

ocefpaf commented Nov 23, 2021

We are seeing a similar breakage in other packages. Newer setuptools and pip are not happy with the newline in the description.

@ocefpaf ocefpaf merged commit 4a0f3d7 into conda-forge:master Nov 23, 2021
@ocefpaf ocefpaf mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants