Skip to content

Update release candidate branch to 3.2.0rc0 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bjlittle merged 7 commits into from
Feb 3, 2022
Merged

Update release candidate branch to 3.2.0rc0 #78

bjlittle merged 7 commits into from
Feb 3, 2022

Conversation

@lbdreyer
Copy link
Contributor

@lbdreyer lbdreyer commented Jan 31, 2022 •
edited
Loading

To create this I took a copy of the recipe from master, updated it to v3.2.0rc0.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

conda-forge-linter commented Jan 31, 2022

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@lbdreyer
Copy link
Contributor Author

lbdreyer commented Jan 31, 2022

@conda-forge-admin, please rerender

@bjlittle
Copy link
Contributor

bjlittle commented Feb 1, 2022

@conda-grayskull show requirements

@conda-grayskull
Copy link

conda-grayskull commented Feb 1, 2022

Working on your request...

bjlittle
bjlittle requested changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbdreyer Looking good, but I've got a couple of outstanding questions, thanks 👍

recipe/meta.yaml
Comment on lines +38 to 47
- name: scitools-iris
build:
noarch: generic
requirements:
run:
- {{ pin_subpackage('iris', max_pin="x.x.x") }}
test:
imports:
- iris
about:
Copy link
Contributor

@bjlittle bjlittle Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbdreyer What's the advantage of doing this?

Copy link
Contributor Author

@lbdreyer lbdreyer Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is a minimal check that it built correctly.

Copy link
Contributor

@bjlittle bjlittle Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that what lines 34-36 are doing?

Copy link
Contributor Author

@lbdreyer lbdreyer Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My interpretation was that they were separate builds, so they each needed testing (this was originally done in https://github.com/conda-forge/iris-feedstock/pull/74/files).

I will have to do a bit more reading to check this though!

Copy link
Contributor Author

@lbdreyer lbdreyer Feb 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if helpful, but I found some other examples of where there is a test for each build output:
https://github.com/conda-forge/typing_extensions-feedstock/blob/master/recipe/meta.yaml#L28-L40
and
https://github.com/conda-forge/gstreamer-feedstock/blob/master/recipe/meta.yaml#L49

Copy link
Contributor

@bjlittle bjlittle Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocefpaf Do you have any guidance/opinion on this?

Copy link
Member

@ocefpaf ocefpaf Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion but I'd keep the extra test b/c it ensure the multiple output is working.

recipe/conda_build_config.yaml
Comment on lines 1 to 2
channel_targets:
- conda-forge rc_iris
Copy link
Contributor

@bjlittle bjlittle Feb 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbdreyer As this is a pre-release, don't we want to populate the rc_iris channel instead of main?

See https://conda-forge.org/docs/maintainer/knowledge_base.html#pre-release-builds

bjlittle
bjlittle reviewed Feb 1, 2022
View reviewed changes
@conda-forge-linter
Copy link

conda-forge-linter commented Feb 1, 2022

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [17].

@lbdreyer
Copy link
Contributor Author

lbdreyer commented Feb 1, 2022

Thanks for the review @bjlittle !
I believe I have addressed your comments now.

bjlittle
bjlittle reviewed Feb 1, 2022
View reviewed changes
@lbdreyer @bjlittle
Update recipe/meta.yaml
7179e2a 
Co-authored-by: Bill Little <[email protected]>
@conda-forge-linter
Copy link

conda-forge-linter commented Feb 1, 2022

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@lbdreyer
Copy link
Contributor Author

lbdreyer commented Feb 1, 2022

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits February 1, 2022 15:57
@lbdreyer
Copy link
Contributor Author

lbdreyer commented Feb 2, 2022

@bjlittle This should now be good to go. I finally figured out why it was failing. It turns out I had the build script line "python -m pip install ..." in the wrong place.
Do you mind having another look at this?

@bjlittle
Copy link
Contributor

bjlittle commented Feb 3, 2022

@lbdreyer Awesome, thanks 🥳

@bjlittle bjlittle merged commit 462be7f into conda-forge:release-candidate Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjlittle bjlittle bjlittle approved these changes

@corinnebosley corinnebosley Awaiting requested review from corinnebosley

@DPeterK DPeterK Awaiting requested review from DPeterK

@ocefpaf ocefpaf Awaiting requested review from ocefpaf

@pelson pelson Awaiting requested review from pelson

@pp-mo pp-mo Awaiting requested review from pp-mo

@rhattersley rhattersley Awaiting requested review from rhattersley

+1 more reviewer

@valeriupredoi valeriupredoi valeriupredoi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lbdreyer @conda-forge-linter @bjlittle @conda-grayskull @ocefpaf @valeriupredoi