Skip to content

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented Mar 26, 2025

This is an automated pull request!

This PR will update the following package:

Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. Checklist before merging this PR:
  • Dependencies have been updated if changed
  • Tests have passed

Closes #307

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@weiji14
Copy link
Member Author

weiji14 commented Mar 26, 2025

Got this error at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1208046&view=logs&j=7b6f2c87-f3a7-5133-8d84-7c03a75d9dfc&t=9eb77fd2-8ddd-5444-8fc0-71cb28dcb736&l=2518:

+ gmt defaults -Vd
gmt: error while loading shared libraries: libmkl_intel_lp64.so.2: cannot open shared object file: No such file or directory

Do we need to explicitly add mkl now? Edit: found this old issue - #2 (comment) with the same error message.

weiji14 added 3 commits March 27, 2025 10:04
Avoid pulling in python related dependencies when installing `gdal` instead of `libgdal`.
@weiji14 weiji14 force-pushed the update/6.6.0.dev5+b3580a7 branch from fb6278f to 0be447b Compare March 26, 2025 21:35
@weiji14
Copy link
Member Author

weiji14 commented Mar 26, 2025

Also getting these warnings:

WARNING (gmt,lib/libgmt.so.6.6.0): Needed DSO lib/libmkl_intel_lp64.so.2 found in ['conda-forge/linux-64::mkl==2024.2.2=ha957f24_16']
WARNING (gmt,lib/libgmt.so.6.6.0): .. but ['conda-forge/linux-64::mkl==2024.2.2=ha957f24_16'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
WARNING (gmt,lib/libgmt.so.6.6.0): Needed DSO lib/libmkl_intel_thread.so.2 found in ['conda-forge/linux-64::mkl==2024.2.2=ha957f24_16']
WARNING (gmt,lib/libgmt.so.6.6.0): .. but ['conda-forge/linux-64::mkl==2024.2.2=ha957f24_16'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)
WARNING (gmt,lib/libgmt.so.6.6.0): Needed DSO lib/libmkl_core.so.2 found in ['conda-forge/linux-64::mkl==2024.2.2=ha957f24_16']
WARNING (gmt,lib/libgmt.so.6.6.0): .. but ['conda-forge/linux-64::mkl==2024.2.2=ha957f24_16'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

@weiji14 weiji14 marked this pull request as ready for review March 27, 2025 01:04
-D ZLIB_ROOT=$PREFIX \
-D CURL_ROOT=$PREFIX \
-D LAPACK_LIBRARIES=$PREFIX/lib/liblapack${SHLIB_EXT} \
-D BLA_VENDOR=Generic \
Copy link
Member Author

@weiji14 weiji14 Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seisman, can you check if this change to use -D BLA_VENDOR=Generic makes sense. I'm not familiar with BLAS/LAPACK and all that, but found conda-forge/sundials-feedstock#118 (comment) and this seems to fix the libmkl_intel_lp64.so.2: cannot open shared object file error on linux-64?

For reference, the -D LAPACK_LIBRARIES=$PREFIX/lib/liblapack${SHLIB_EXT} line was added by Leo back in 2017 at #24

Comment on lines -32 to -34
- libblas
- libcblas
- liblapack
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these from runtime, based on https://conda-forge.org/docs/maintainer/knowledge_base/#blas saying that these should only be needed on host?

recipe/meta.yaml Outdated
- liblapack
- {{ pin_compatible('fftw', max_pin='x') }}
- {{ pin_compatible('gdal', max_pin='x.x') }}
- {{ pin_compatible('libgdal-core', max_pin='x.x') }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching from gdal to libgdal-core, because gdal contains Python related dependencies that shouldn't be needed in GMT C.

@weiji14
Copy link
Member Author

weiji14 commented Mar 27, 2025

I've also cherry-picked the GEOS 3.13.1 migration from #307 into this PR, so can close that one after this is merged.

Other dependencies aren't really sorted, but trying to minimize diff first
@seisman seisman merged commit c5f7317 into conda-forge:devel Mar 27, 2025
9 checks passed
@seisman seisman deleted the update/6.6.0.dev5+b3580a7 branch March 27, 2025 03:13
weiji14 added a commit to weiji14/gmt-feedstock that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants