Skip to content

Conversation

@leouieda
Copy link
Member

Trying to avoid linking problems with OSX Accelerate framework.
Suggested by @isuruf in #3

Trying to avoid linking problems with OSX Accelerate framework.
Suggested by @isuruf in #3
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

recipe/meta.yaml Outdated
- blas 1.1 {{ variant }}
- curl
- pcre
- lapack
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this with openblas 0.2.19|0.2.19.*. openblas is an optimized blas and lapack library and is better than lapack which is the reference implementation with no optimization

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But should I keep blas 1.1?

Are you sure openblas has LAPACK? I can't find any mention of it on their website.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blas 1.1 is there to have one implementation of blas per env. @ocefpaf, @jakirkham can explain better than me.

Yes, I'm sure openblas has lapack

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the docs. Yes openblas implements both the BLAS and LAPACK interfaces within the same library. So it serves both purposes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for the explanation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I realize that doc mention was super terse. If you have any questions, please feel free to ask.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakirkham not at al. I didn't think to look in the conda-forge docs and it's good to know that the information is there. Reply time for all conda-forge is impressively low!

@leouieda leouieda merged commit f3656ef into conda-forge:master Sep 25, 2017
@leouieda leouieda deleted the lapack branch September 25, 2017 23:26

build:
number: 2
number: 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI with openblas this should start at 200 and go up from there or be reset to 200 when making a new release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakirkham OK. So should I maintain multiple builds/branches with and without openblas?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakirkham should I update the build number now or wait until the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants