-
-
Notifications
You must be signed in to change notification settings - Fork 12
Set LAPACK path #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set LAPACK path #24
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipe/meta.yaml
Outdated
| - blas 1.1 {{ variant }} | ||
| - curl | ||
| - pcre | ||
| - lapack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this with openblas 0.2.19|0.2.19.*. openblas is an optimized blas and lapack library and is better than lapack which is the reference implementation with no optimization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But should I keep blas 1.1?
Are you sure openblas has LAPACK? I can't find any mention of it on their website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blas 1.1 is there to have one implementation of blas per env. @ocefpaf, @jakirkham can explain better than me.
Yes, I'm sure openblas has lapack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are the docs. Yes openblas implements both the BLAS and LAPACK interfaces within the same library. So it serves both purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks for the explanation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I realize that doc mention was super terse. If you have any questions, please feel free to ask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakirkham not at al. I didn't think to look in the conda-forge docs and it's good to know that the information is there. Reply time for all conda-forge is impressively low!
|
|
||
| build: | ||
| number: 2 | ||
| number: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI with openblas this should start at 200 and go up from there or be reset to 200 when making a new release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakirkham OK. So should I maintain multiple builds/branches with and without openblas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakirkham should I update the build number now or wait until the next release?
Trying to avoid linking problems with OSX Accelerate framework.
Suggested by @isuruf in #3