Skip to content

Add sphinx theme builder & bump to 2022.2.23#27

Merged
gforsyth merged 16 commits into
conda-forge:masterfrom
gforsyth:sphinx-theme-builder
Mar 5, 2022
Merged

Add sphinx theme builder & bump to 2022.2.23#27
gforsyth merged 16 commits into
conda-forge:masterfrom
gforsyth:sphinx-theme-builder

Conversation

@gforsyth

@gforsyth gforsyth commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@gforsyth gforsyth requested a review from asmeurer as a code owner March 2, 2022 15:57
@conda-forge-linter

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@gforsyth gforsyth force-pushed the sphinx-theme-builder branch from d30247c to 3f581a1 Compare March 2, 2022 16:04
@gforsyth gforsyth closed this Mar 2, 2022
@gforsyth gforsyth reopened this Mar 2, 2022
@gforsyth gforsyth closed this Mar 2, 2022
@gforsyth gforsyth reopened this Mar 2, 2022
@asmeurer

asmeurer commented Mar 2, 2022

Copy link
Copy Markdown
Member

Do we need node as a build requirement?

@asmeurer

asmeurer commented Mar 3, 2022

Copy link
Copy Markdown
Member

No idea. @pradyunsg do you know how to get the build working here? Also we can add you as a feedstock maintainer if you want.

@pradyunsg

Copy link
Copy Markdown

You'll need to set STB_USE_SYSTEM_NODE before invoking the build system.

See pradyunsg/sphinx-theme-builder#7 (comment)

@asmeurer

asmeurer commented Mar 3, 2022

Copy link
Copy Markdown
Member

Hmm, the exact version (16.13.1) isn't on conda-forge.

We need nodejs 16.13.1 which isn't in conda-forge
@asmeurer

asmeurer commented Mar 3, 2022

Copy link
Copy Markdown
Member

It is in defaults, though. I tried adding defaults as per https://conda-forge.org/docs/maintainer/conda_forge_yml.html?highlight=defaults#channels, but it didn't work. @conda-forge/help-python any idea why this isn't working?

@carterbox

Copy link
Copy Markdown
Member

@conda-forge-admin, please rerender

@carterbox

Copy link
Copy Markdown
Member

We have nodejs=16.13.2, does that version not work?

Comment thread conda-forge.yml Outdated
Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>
@asmeurer

asmeurer commented Mar 3, 2022

Copy link
Copy Markdown
Member

@carterbox no, see the link in @pradyunsg's comment above. The version has to match exactly or else sphinx-theme-builder won't pick it up.

We could also try building that version, but it didn't seem straightforward to me. I did notice that 16.13.2 was on anaconda.org, but I didn't find it in the nodejs-feedstock git history. Presumably a 16.13.1 build should reuse the 16.13.2 meta.yaml, since there are many patches in that recipe that would likely not work unless they match the right version.

@carterbox

Copy link
Copy Markdown
Member

@conda-forge-admin, please rerender

@conda-forge-linter

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@carterbox

Copy link
Copy Markdown
Member

@conda-forge-admin, please rerender

@github-actions

github-actions Bot commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/furo-feedstock/actions/runs/1931251051.

@carterbox

Copy link
Copy Markdown
Member

@gforsyth, please resolve the merge conflict

@asmeurer, if still doesn't work after conflict resolution and rerender, you can open a PR on https://github.com/conda-forge/nodejs-feedstock/pulls for the missing version.

We should open a bug report to report mambabuild ignoring channels.

@asmeurer

asmeurer commented Mar 4, 2022

Copy link
Copy Markdown
Member

@gforsyth, please resolve the merge conflict

@carterbox the merge is caused by your suggested change. I'm a little unclear which way it should be resolved.

@asmeurer, if still doesn't work after conflict resolution and rerender, you can open a PR on conda-forge/nodejs-feedstock/pulls for the missing version.

I'd prefer to avoid this for the reasons I mentioned above.

@carterbox

Copy link
Copy Markdown
Member

I'm a little unclear which way it should be resolved.

GitHub doesn't show me conflict because I am not a maintainer of this feedstock.

Unless the conflict is in conda-forge.yml or recipe/, (on your local machine) please manually merge the upstream branch and then rerender using conda-smithy. The merge conflict is probably in one of the files that are manage by conda-smithy.

@conda-forge-linter

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@asmeurer

asmeurer commented Mar 5, 2022

Copy link
Copy Markdown
Member

@conda-forge-admin rerender.

@asmeurer

asmeurer commented Mar 5, 2022

Copy link
Copy Markdown
Member

Fixed the merge conflict. It looks like it is using conda-build, but it still isn't able to find the given version of node.

@carterbox

Copy link
Copy Markdown
Member

The issue we're having is documented in conda-forge/conda-smithy#897. The conda-forge.yml documentation is out of date. Please put the channel information in a new conda_build_config.yaml in your recipe directory following step 4 here: https://github.com/conda-forge/conda-smithy#making-a-new-feedstock

Note the syntax of commas with no spaces. This step 4 is also out of date because it looks like defaults is not included by default anymore which is why you will need to explicitly add it.

Something like:

channel_sources:
  - conda-forge,defaults

Please remember to rerender afterwards, and you can remove all the new additions to conda-forge.yml.

@asmeurer

asmeurer commented Mar 5, 2022

Copy link
Copy Markdown
Member

@conda-forge-admin rerender

@carterbox carterbox left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"recipe/conda_build_config.yaml" check the filename, please.

@pradyunsg

Copy link
Copy Markdown

If it makes things easier, I can cut a release with a newer NodeJS requirement in Furo.

@gforsyth

gforsyth commented Mar 5, 2022

Copy link
Copy Markdown
Contributor Author

It's green, I'm merging. Thanks to all for getting this through.

When the upstream version of node is updated we can remove defaults (but no rush @pradyunsg -- greatly appreciate the offer, though)

@gforsyth gforsyth merged commit a734d33 into conda-forge:master Mar 5, 2022
@gforsyth gforsyth deleted the sphinx-theme-builder branch March 5, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants