Add sphinx theme builder & bump to 2022.2.23#27
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
d30247c to
3f581a1
Compare
|
Do we need node as a build requirement? |
|
No idea. @pradyunsg do you know how to get the build working here? Also we can add you as a feedstock maintainer if you want. |
|
You'll need to set STB_USE_SYSTEM_NODE before invoking the build system. |
|
Hmm, the exact version (16.13.1) isn't on conda-forge. |
We need nodejs 16.13.1 which isn't in conda-forge
|
It is in defaults, though. I tried adding |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.03.03.21.25.39
|
We have |
Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>
|
@carterbox no, see the link in @pradyunsg's comment above. The version has to match exactly or else sphinx-theme-builder won't pick it up. We could also try building that version, but it didn't seem straightforward to me. I did notice that 16.13.2 was on anaconda.org, but I didn't find it in the nodejs-feedstock git history. Presumably a 16.13.1 build should reuse the 16.13.2 meta.yaml, since there are many patches in that recipe that would likely not work unless they match the right version. |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.03.03.21.25.39
|
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/furo-feedstock/actions/runs/1931251051. |
|
@gforsyth, please resolve the merge conflict @asmeurer, if still doesn't work after conflict resolution and rerender, you can open a PR on https://github.com/conda-forge/nodejs-feedstock/pulls for the missing version. We should open a bug report to report mambabuild ignoring channels. |
@carterbox the merge is caused by your suggested change. I'm a little unclear which way it should be resolved.
I'd prefer to avoid this for the reasons I mentioned above. |
GitHub doesn't show me conflict because I am not a maintainer of this feedstock. Unless the conflict is in |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin rerender. |
…nda-forge-pinning 2022.03.04.19.31.39
|
Fixed the merge conflict. It looks like it is using conda-build, but it still isn't able to find the given version of node. |
|
The issue we're having is documented in conda-forge/conda-smithy#897. The conda-forge.yml documentation is out of date. Please put the channel information in a new conda_build_config.yaml in your recipe directory following step 4 here: https://github.com/conda-forge/conda-smithy#making-a-new-feedstock Note the syntax of commas with no spaces. This step 4 is also out of date because it looks like defaults is not included by default anymore which is why you will need to explicitly add it. Something like: channel_sources:
- conda-forge,defaultsPlease remember to rerender afterwards, and you can remove all the new additions to conda-forge.yml. |
|
@conda-forge-admin rerender |
…nda-forge-pinning 2022.03.04.19.31.39
carterbox
left a comment
There was a problem hiding this comment.
"recipe/conda_build_config.yaml" check the filename, please.
|
If it makes things easier, I can cut a release with a newer NodeJS requirement in Furo. |
…nda-forge-pinning 2022.03.05.07.13.09
|
It's green, I'm merging. Thanks to all for getting this through. When the upstream version of node is updated we can remove defaults (but no rush @pradyunsg -- greatly appreciate the offer, though) |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)