DOC: Update feedstock channel selection docs#1620
Merged
Merged
Conversation
Member
|
As I said in conda-forge/conda-smithy#897, the README needs |
Member
Author
|
Oh. You're saying that the README generated by smithy reads |
3 tasks
1 task
jaimergp
reviewed
Oct 31, 2023
jaimergp
approved these changes
Oct 31, 2023
2 tasks
jdblischak
approved these changes
Dec 12, 2023
| # channel to push to and the second element is the label on that channel | ||
| targets: | ||
| - ["conda-forge", "main"] | ||
| This parameter is obsolete. Instead, specify channels in ``recipe/conda_build_config.yaml`` |
Member
There was a problem hiding this comment.
Just a suggestion:
Suggested change
| This parameter is obsolete. Instead, specify channels in ``recipe/conda_build_config.yaml`` | |
| This parameter is obsolete as of 2023-11-07 when `conda-smithy 3.28.0 <https://github.com/conda-forge/conda-smithy/releases/tag/v3.28.0>`_ was released. Instead, specify channels in ``recipe/conda_build_config.yaml`` |
jaimergp
added a commit
to carterbox/conda-forge.github.io
that referenced
this pull request
Feb 26, 2024
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Documentation for channel sources and targets are out of date. This setting is now managed in conda_build_config Related conda-forge/conda-smithy#897 https://github.com/conda-forge/conda-smithy/blob/9f81a068e8f23f2aae670469b473da786d49d8ef/README.md Co-authored-by: Isuru Fernando <isuruf@gmail.com> Co-authored-by: Daniel Ching <carterbox@users.noreply.github.com>
jaimergp
approved these changes
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2026
Documentation for channel sources and targets are out of date. This
setting is now managed in conda_build_config
Related
conda-forge/conda-smithy#897
https://github.com/conda-forge/conda-smithy/blob/9f81a068e8f23f2aae670469b473da786d49d8ef/README.md
Prompted by
conda-forge/furo-feedstock#27
PR Checklist:
srcdirectory, not indocsor in the html files- [ ] note any issues closed by this PR with closing keywords- [ ] put any other relevant information below