Skip to content

Rebuild for CFEP-25 noarch: python syntax#81

Merged
bouweandela merged 2 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:noarch_python_min-migration-1_hc2d33b
Dec 27, 2024
Merged

Rebuild for CFEP-25 noarch: python syntax#81
bouweandela merged 2 commits intoconda-forge:mainfrom
regro-cf-autotick-bot:noarch_python_min-migration-1_hc2d33b

Conversation

@regro-cf-autotick-bot
Copy link
Copy Markdown
Contributor

This PR updates the recipe to use the noarch: python syntax as described in CFEP-25. Please see our documentation for more details.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12511334655 - please use this URL for debugging.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@bouweandela bouweandela merged commit e478bd9 into conda-forge:main Dec 27, 2024
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the noarch_python_min-migration-1_hc2d33b branch December 27, 2024 18:22
@valeriupredoi
Copy link
Copy Markdown
Contributor

thanks @bouweandela - I guess we need to comply, but this standard is rather annoyingly implemented ugh

@valeriupredoi
Copy link
Copy Markdown
Contributor

@valeriupredoi
Copy link
Copy Markdown
Contributor

OK it's running the build and build tests with Python 3.10 and old Numpy and a bunch other old things, this is total BS what conda-forge is forcing us to do, am changing this now

@valeriupredoi
Copy link
Copy Markdown
Contributor

valeriupredoi commented Jan 6, 2025

aagh so annoying - so the auto PR makes changes to the core deps and changes the build number, but it's got skip-build activated, well done, conda-forge, well done! You really should have looked at this a bit more closely, bud, but eh Xmas time 😁

@bouweandela
Copy link
Copy Markdown
Contributor

The build ran just fine on the branch in this pull request: https://github.com/conda-forge/esmvalcore-feedstock/runs/34903728113, but it looks like some tests failed once this branch got merged into main because of the new iris patch release, the changes in SciTools/iris#6260 broke two of our tests.

@valeriupredoi
Copy link
Copy Markdown
Contributor

thanks @bouweandela - I must have been blind yesterday, it indeed ran the build, rather thank skip it. At any rate, I am going to open a PR now to have our tests run with the latest Python - I don't agree at all with what c-f say we should run build tests with the minimum Python, we have CI for that. I am well puzzled why the tests don't fail upstream with the iris 3.11.1 patch though

@bouweandela
Copy link
Copy Markdown
Contributor

bouweandela commented Jan 7, 2025

why the tests don't fail upstream with the iris 3.11.1 patch though

They were failing, but I fixed them in ESMValGroup/ESMValCore#2622

@valeriupredoi
Copy link
Copy Markdown
Contributor

ah that PR went in on my first day off, that explains things now, cheers 🍺

@valeriupredoi valeriupredoi mentioned this pull request Feb 14, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants