Conversation
Member
Author
|
I'll keep this in draft until we can test with iris 3.11.1 and cf_units 3.3. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2622 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 253 253
Lines 14696 14701 +5
=======================================
+ Hits 13956 13961 +5
Misses 740 740 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a new
iris.FUTUREflag in iris 3.11.1 and it would be good to set that because not doing that will cause a performance degradation. Moved all the flags to the config module to keep them in one place.This also fixes the failing tests on main: https://app.circleci.com/pipelines/github/ESMValGroup/ESMValCore/12309/workflows/ec7ef641-9cde-4354-87c6-c70fc3e0244b
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: