Skip to content

Set iris.FUTURE flags in one place#2622

Merged
schlunma merged 2 commits intomainfrom
iris-flags
Dec 20, 2024
Merged

Set iris.FUTURE flags in one place#2622
schlunma merged 2 commits intomainfrom
iris-flags

Conversation

@bouweandela
Copy link
Copy Markdown
Member

@bouweandela bouweandela commented Dec 19, 2024

Description

There is a new iris.FUTURE flag in iris 3.11.1 and it would be good to set that because not doing that will cause a performance degradation. Moved all the flags to the config module to keep them in one place.

This also fixes the failing tests on main: https://app.circleci.com/pipelines/github/ESMValGroup/ESMValCore/12309/workflows/ec7ef641-9cde-4354-87c6-c70fc3e0244b


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela
Copy link
Copy Markdown
Member Author

I'll keep this in draft until we can test with iris 3.11.1 and cf_units 3.3.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (23400b1) to head (1adfcb8).
Report is 59 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2622   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files         253      253           
  Lines       14696    14701    +5     
=======================================
+ Hits        13956    13961    +5     
  Misses        740      740           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela marked this pull request as ready for review December 20, 2024 14:23
@schlunma schlunma added this to the v2.12.0 milestone Dec 20, 2024
@schlunma schlunma added the iris Related to the Iris package label Dec 20, 2024
Copy link
Copy Markdown
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bouwe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

iris Related to the Iris package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants