Skip to content

add clang 19.1#131

Merged
isuruf merged 12 commits into
conda-forge:mainfrom
h-vetinari:clang19
Nov 15, 2024
Merged

add clang 19.1#131
isuruf merged 12 commits into
conda-forge:mainfrom
h-vetinari:clang19

Conversation

@h-vetinari

Copy link
Copy Markdown
Member

No description provided.

@conda-forge-webservices

conda-forge-webservices Bot commented Sep 21, 2024

Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari h-vetinari changed the title Add clang 19 Add clang 19.1 Sep 21, 2024
@h-vetinari h-vetinari changed the title Add clang 19.1 add clang 19.1 Sep 21, 2024
@h-vetinari

Copy link
Copy Markdown
Member Author

This PR (as of 454ff7f) needs conda-forge/clangdev-feedstock@d21fa80 (from conda-forge/clangdev-feedstock#322), plus backports of that commit to 17.x & 18.x

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • Recipe maintainer "isuruf" does not exist
  • Recipe maintainer "beckermr" does not exist

@h-vetinari

Copy link
Copy Markdown
Member Author
  • Recipe maintainer "beckermr" does not exist

@beckermr, the linter seems to believe you have ceased existing 🤭

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari h-vetinari force-pushed the clang19 branch 2 times, most recently from 3ae5622 to 704ac74 Compare October 9, 2024 04:02
@h-vetinari

Copy link
Copy Markdown
Member Author

This should now be ready, PTAL @conda-forge/ctng-compiler-activation

With conda-forge/clangdev-feedstock@5751f79 after discussion in conda-forge/clangdev-feedstock#322, we now mirror clang_impl_{{ target }} also on the linux side, but on this feedstock.

I've tried matching the structure of the scripts with the clang-compiler-activation, and I'll also rename the scripts on the clang-activation to match the script naming here, so ultimately we converge to a recognizably similar setup despite being spread across different feedstocks.

@h-vetinari

Copy link
Copy Markdown
Member Author

Gentle ping @isuruf

Comment thread recipe/conda_build_config.yaml
Comment thread recipe/meta.yaml Outdated
though it hasn't happened since LLVM 11, it's possible that
there are ABI-(un)breaking changes within a major line
isuruf
isuruf previously requested changes Oct 21, 2024

@isuruf isuruf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a conda-build bug and this needs a rerender with an older version to make sure the .ci_support are not duplicated.

Taken over from clangdev feedstock, see
conda-forge/clangdev-feedstock@5751f79
but matching the structure structure of clang{,xx}_impl scripts for osx, see
https://github.com/conda-forge/clang-compiler-activation-feedstock/blob/main/recipe
we're not packaging target-specific clangs (it's all the same build behind the
various symlinks), so just use the actual target we're building a compiler for.
Comment thread recipe/install-clangxx_impl.sh Outdated
Comment thread recipe/meta.yaml
@h-vetinari

Copy link
Copy Markdown
Member Author

These are unnecessary with the sysroot update

Just for my understanding: Does clang pick up the .cfg's even if only part of the binary path matches? Before we had

bin/x86_64-conda-linux-gnu-clang.cfg
bin/x86_64-conda-linux-gnu-clang++.cfg
bin/x86_64-conda-linux-gnu-clang-cpp.cfg

after conda-forge/linux-sysroot-feedstock@c53a630 we now only have

bin/x86_64-conda-linux-gnu.cfg

@isuruf

isuruf commented Oct 25, 2024

Copy link
Copy Markdown
Member

The rules for the names are in https://clang.llvm.org/docs/UsersManual.html#configuration-files. It searches for <triple>-<driver>.cfg and <triple>.cfg.

@h-vetinari

Copy link
Copy Markdown
Member Author

Thanks, that makes sense! Anything else to do here?

Comment thread recipe/install-clang++.sh Outdated
Comment thread recipe/install-clang.sh Outdated
Comment thread recipe/meta.yaml Outdated
Comment thread recipe/meta.yaml
@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • pin_compatible should be used instead of pin_subpackage for clang_impllinux-64 because it is not a known output of this recipe: ['gcc_linux-64', 'clang_impl_linux-64', 'clang_linux-64', 'gxx_linux-64', 'clangxx_impl_linux-64', 'clangxx_linux-64', 'gfortran_linux-64', 'gcc_bootstrap_linux-64', 'ctng-compiler-activation'].

Comment thread recipe/meta.yaml Outdated
@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari

Copy link
Copy Markdown
Member Author

Are we good here now @isuruf? :)

@h-vetinari

Copy link
Copy Markdown
Member Author

Ping @isuruf

1 similar comment
@h-vetinari

Copy link
Copy Markdown
Member Author

Ping @isuruf

@h-vetinari h-vetinari dismissed isuruf’s stale review November 13, 2024 23:29

The issue with the conda-build bug has been addressed in this PR (and ideally a fix may even make it into CB 24.11 🤞)

@h-vetinari

Copy link
Copy Markdown
Member Author

@isuruf, this has been ready for >2 weeks and is just missing a merge. Given your preference of me not joining as a maintainer, please help me finish this. The alternative is that I bring up shared compiler maintenance (i.e. me joining the GCC & VC feedstocks) in core, up to a vote if necessary.

@isuruf isuruf merged commit 3648ba7 into conda-forge:main Nov 15, 2024
@isuruf

isuruf commented Nov 15, 2024

Copy link
Copy Markdown
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants