add clang 19.1#131
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
This PR (as of 454ff7f) needs conda-forge/clangdev-feedstock@d21fa80 (from conda-forge/clangdev-feedstock#322), plus backports of that commit to 17.x & 18.x |
abe7010 to
af0d58e
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
@beckermr, the linter seems to believe you have ceased existing 🤭 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
3ae5622 to
704ac74
Compare
|
This should now be ready, PTAL @conda-forge/ctng-compiler-activation With conda-forge/clangdev-feedstock@5751f79 after discussion in conda-forge/clangdev-feedstock#322, we now mirror I've tried matching the structure of the scripts with the clang-compiler-activation, and I'll also rename the scripts on the clang-activation to match the script naming here, so ultimately we converge to a recognizably similar setup despite being spread across different feedstocks. |
|
Gentle ping @isuruf |
though it hasn't happened since LLVM 11, it's possible that there are ABI-(un)breaking changes within a major line
isuruf
left a comment
There was a problem hiding this comment.
There's a conda-build bug and this needs a rerender with an older version to make sure the .ci_support are not duplicated.
Taken over from clangdev feedstock, see conda-forge/clangdev-feedstock@5751f79 but matching the structure structure of clang{,xx}_impl scripts for osx, see https://github.com/conda-forge/clang-compiler-activation-feedstock/blob/main/recipe
we're not packaging target-specific clangs (it's all the same build behind the various symlinks), so just use the actual target we're building a compiler for.
Just for my understanding: Does clang pick up the after conda-forge/linux-sysroot-feedstock@c53a630 we now only have |
|
The rules for the names are in https://clang.llvm.org/docs/UsersManual.html#configuration-files. It searches for |
|
Thanks, that makes sense! Anything else to do here? |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Are we good here now @isuruf? :) |
|
Ping @isuruf |
1 similar comment
|
Ping @isuruf |
The issue with the conda-build bug has been addressed in this PR (and ideally a fix may even make it into CB 24.11 🤞)
|
@isuruf, this has been ready for >2 weeks and is just missing a merge. Given your preference of me not joining as a maintainer, please help me finish this. The alternative is that I bring up shared compiler maintenance (i.e. me joining the GCC & VC feedstocks) in core, up to a vote if necessary. |
|
Thanks |
No description provided.