Fix pinnings for ppc64le with enabled CUDA#7684
Merged
Merged
Conversation
Following the merge of conda-forge#7660, the rerender of my recipe fails with: ``` ValueError: Variant configuration errors in /home/fs/.cache/conda-smithy/conda_build_config.yaml: zip fields in zip_key group frozenset({'cuda_compiler_version', 'c_stdlib_version', 'cxx_compiler_version', 'fortran_compiler_version', 'c_compiler_version'}) are not all the same length ``` This is due to having two output packages, one without CUDA support but built for all platforms including ppc64le, and one with CUDA support but restricted to `linux_64` and `linux_aarch64`. With the current pinning, for the `linux_ppc64le` platform, the resulting pinnings are: ```yaml c_compiler_version: # [unix] - 14 # [linux] c_stdlib_version: # [unix] - 2.17 # [linux] - 2.17 # [linux and os.environ.get("CF_CUDA_ENABLED", "False") == "True"] cxx_compiler_version: # [unix] - 14 # [linux] fortran_compiler_version: # [unix or win64] - 14 # [linux] cuda_compiler_version: - None ```
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
approved these changes
Aug 21, 2025
h-vetinari
left a comment
Member
There was a problem hiding this comment.
Thank you very much. Indeed, that was due to those two PRs crossing wires.
Member
|
I also double-checked that we don't need the same selector modification here: This is fine because the cuda 11.8 migrator sets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the merges of #7660 and #7653, the rerender of my recipe fails with:
This is due to having two output packages, one without CUDA support but built for all platforms including
linux_ppc64le, and one with CUDA support but restricted tolinux_64andlinux_aarch64. In this edge case, for thelinux_ppc64leplatform, the resulting pinnings are:I thus propose using the same selector on
c_stdlib_versionthan on other keys to remove the second entry for theppc64leplatform: