NEW: Migrate recipes to CUDA 13.0#7653
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
h-vetinari
left a comment
There was a problem hiding this comment.
looks pretty good already!
h-vetinari
left a comment
There was a problem hiding this comment.
Since we haven't closed the 12.9 migration yet, it would be good to test that the presence of both cuda129.yaml and cuda130.yaml does the right thing.
|
With the changes to the global zip this becomes a bit harder to test locally, but it's still possible. You need to use the At first I wanted to use conda-forge-pinning-feedstock/recipe/migrations/python313t.yaml Lines 27 to 29 in c456e01 This would postpone having to modify the global pinning until we close the 13.0 migration. But I wasn't able to get this work, it fails in smithy with Since the question is just when we add |
…while cuda13.0 migration is still being worked on
h-vetinari
left a comment
There was a problem hiding this comment.
From my POV, this is good to go
|
There's still some bugs in the Windows CUDA 13.0 build for libastra which AFAIK is the only compiled feedstock that this migrator has been tested against. Until we have a few examples of non-redist packages successfully building with the CUDA 13.0 CTK, I'd prefer not to start the migration. |
|
We could try it on some feedstock like libmagma, etc.? Preferably not yet something with lots of expensive CI jobs (e.g. pytorch). |
One thing we could do to ease testing of this on feedstocks (due to the zip-changes), is to merge this with |
|
Yes, that's a great idea @h-vetinari! @billysuh7 @carterbox I'd recommend that we go with that approach when we pick this up again on Monday. |
I just tried to build magma, it's not a good test recipe because it doesn't support CUDA 13 yet. It runs into some of the breaking changes at compile time. |
| `sm_110`. To build for these, maintainers will need to modify their existing list of | ||
| specified architectures (e.g. `CMAKE_CUDA_ARCHITECTURES`, `TORCH_CUDA_ARCH_LIST`, etc.) | ||
| for their package. | ||
|
|
There was a problem hiding this comment.
Insert note here about binary path changes on Windows
There was a problem hiding this comment.
Do you want to do this before merging the still-paused migration? We could also add that text later.
There was a problem hiding this comment.
No, I don't want to add the note because we may be reverting the path changes on Windows.
| `sm_110`. To build for these, maintainers will need to modify their existing list of | ||
| specified architectures (e.g. `CMAKE_CUDA_ARCHITECTURES`, `TORCH_CUDA_ARCH_LIST`, etc.) | ||
| for their package. | ||
|
|
There was a problem hiding this comment.
Do you want to do this before merging the still-paused migration? We could also add that text later.
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17103079363. Examine the logs at this URL for more detail. |
|
As discussed in the core call. Let's merge as paused, and figure out the remaining issues before unpausing. |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Test Feedstocks:
NVCOMPNot built from sourceBlocking Issues: