use different name for CUDA 11.8 opt-in migrator#7487
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
conda-forge/cupy-feedstock#309 shows how to use this PR and #7476 together to enable support for CUDA 12.9 & 11.8. I don't think we should change the filename because the announcement points to it. Coming from there, the only difficulty that caused me to struggle is |
Given that it's a real, live migrator (even if paused), the What did you observe? (if you're talking about |
The CI pipelines for the migrator that does not have |
What matters is whether a migrator with the same filename is found in content of the latest
As I said, I suspect strongly that this was only the cast for Footnotes
|
closing as obsolete; the accuracy of the info on the status page is not that important |
I just noticed a problem with #7472 / #7432: we ended up using the exact same filename for the migrator (
cuda118.yaml) as the original CUDA 11.8 migration (c.f. #5340, #4834)The detection mechanism in the migrator infrastructure whether a given feedstock has been migrated is based on that filename, and consequently, it thinks that ~90 feedstocks have opted into re-adding cuda 11.8 -- though this is just because it's reusing the "done" status from the old migrator, not because those 90 feedstocks still have the migrator file present.
By reusing the name, we effectively make it impossible for #7431 to take effect on feedstocks that still have the old migrator lying around. Luckily, there's currently just two that are affected (arrow was intentional, and prismatic_split is archived):
So overall, it's probably fine to keep using the old migrator filename. The only real consequence is that the status page becomes useless, but that's not such a big deal. If however people do want to fix this, we should do it soon, before any more feedstocks start using the migrator as instructed in the announcement.