[WIP] Add CUDA 11.8 manual migrator#7432
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
7b3b3cd to
fedf706
Compare
| ordering: | ||
| cuda_compiler: | ||
| - None | ||
| - cuda-nvcc | ||
| - nvcc | ||
| cuda_compiler_version: | ||
| - None | ||
| - 12.4 | ||
| - 12.6 | ||
| - 12.8 | ||
| - 12.9 | ||
| - 11.8 |
There was a problem hiding this comment.
It looks like we need to add CUDA 11.8 last in the ordering for this to work correctly
With that in place this does appear to do the right thing
dbc4c7a to
06d37f7
Compare
Provide a manual migrator that recipe maintainers can use to readd CUDA 11.8 after we drop it from the global pinnings.
06d37f7 to
7372cd4
Compare
| document-start: disable | ||
| line-length: | ||
| max: 180 | ||
| max: 260 |
There was a problem hiding this comment.
The Docker image lines with selectors get kind of long. Already squeezed them down quite a bit
Needed to bump this to keep the linter happy
|
Thanks for doing this. I agree it's nice to provide a migrator for people to copy (even though I suspect it won't see much use 🤷). Did you test it with the state of #74311? Due to the zipping change (removing Footnotes
|
|
Yeah exactly was testing with your PR removing CUDA 11.8 (and the Think this is why we needed the ordering flipped for adding CUDA 11.8 above Previously CUDA 11.8 would have been earlier in the list, but that causes problems without |
|
Could you test it one last time now that |
We are planning to drop CUDA 11.8 from the global pinnings as discussed in issue: #7404
Following the pattern that we have used in the past to readd old CUDA version like with PR: #1657
Provide a manual migrator that recipe maintainers can use to readd CUDA 11.8 in their feedstocks.