Skip to content

Drop CUDA 11.2#5799

Merged
h-vetinari merged 2 commits into
conda-forge:mainfrom
h-vetinari:cuda_swap
May 1, 2024
Merged

Drop CUDA 11.2#5799
h-vetinari merged 2 commits into
conda-forge:mainfrom
h-vetinari:cuda_swap

Conversation

@h-vetinari

Copy link
Copy Markdown
Member

The 22nd of April has passed (where we announced we'd drop CUDA 11.2). This is a variant of #5613 that drops 11.2 and incorporates the various review requests there.

Co-Authored-By: H. Vetinari <h.vetinari@gmx.com>
@h-vetinari h-vetinari requested a review from a team as a code owner April 23, 2024 03:48
@conda-forge-webservices

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari mentioned this pull request Apr 23, 2024
5 tasks

@jakirkham jakirkham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Axel! 🙏

Let's stick to dropping CUDA 11.2 here

We can finish our discussion of how CUDA 12 is added in PR: #5613

@h-vetinari

Copy link
Copy Markdown
Member Author

We can finish our discussion of how CUDA 12 is added in PR: #5613

Sure we can discuss there.

Let's stick to dropping CUDA 11.2 here

I'd prefer to do both at the same time.

@h-vetinari

h-vetinari commented Apr 23, 2024

Copy link
Copy Markdown
Member Author

I'd prefer to do both at the same time.

It's more than a preference actually. If we don't do it at the same time, we'll break feedstocks that override a GCC version on a CUDA-enabled feedstock. I've recently had to do that for arrow: conda-forge/arrow-cpp-feedstock@af240dc

(The arrow feedstock will still need fixing afterwards, but at least my approach wouldn't break the bot from opening upgrade PRs.)

@h-vetinari

Copy link
Copy Markdown
Member Author

Friendly ping @jakirkham. I say we should avoid changing the lengths of the compiler-version zip without a migration, unless there is an urgent overriding cause. I don't see one here. Happy to discuss this in the core call if you prefer.

@jakirkham

Copy link
Copy Markdown
Member

Thanks for the reminder! Have been a bit swamped recently

Interesting context. Yeah let's discuss in the core call. Added to the agenda

@jakirkham

Copy link
Copy Markdown
Member

Based on discussion in the core call, it sounds like we are ok with dropping CUDA 11.2 on its own. Would it be alright if we update this PR to reflect that? Then think we can merge

@h-vetinari

Copy link
Copy Markdown
Member Author

Based on discussion in the core call, it sounds like we are ok with dropping CUDA 11.2 on its own.

That's not exactly what was discussed IMO, but given that we've deferred the closing of the 12.0 migration for now, I'm fine to close 11.2 separately and deal with the fall-out in arrow.

@jakirkham

Copy link
Copy Markdown
Member

Am happy to also look at Arrow if you need a hand

@h-vetinari

Copy link
Copy Markdown
Member Author

Am happy to also look at Arrow if you need a hand

It's fine, thanks. I know how to do it, I just didn't want the migration bots to stop issuing PRs due to this.

@h-vetinari h-vetinari changed the title Close CUDA 12.0 migration, drop CUDA 11.2 Drop CUDA 11.2 May 1, 2024
@jakirkham

Copy link
Copy Markdown
Member

Completely understand

@jakirkham

Copy link
Copy Markdown
Member

Thanks Axel! 🙏

Have gone ahead and approved. Please feel free to merge when you are ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants