Close CUDA 12.0 migration by jakirkham · Pull Request #5613 · conda-forge/conda-forge-pinning-feedstock

jakirkham · 2024-03-09T02:57:16Z

Now that a large majority of feedstocks have been rebuilt or have an open migration PR, let's go ahead and close out this PR and add CUDA 12 to the matrix.

This adds CUDA 12.0 & CUDA 12.4. Where CUDA 12.0 represents the oldest CUDA 12 version built against and supported in conda-forge. Similarly CUDA 12.4 represents the latest CUDA version in conda-forge. This way if users are still have packages that depend on an older CUDA 12 version, packages built with CUDA 12.0 will satisfy that need. Also if users are trying to take advantage of packages built with the latest optimizations, they can install packages built with the latest CUDA Toolkit in conda-forge. We keep the latest version pinned to avoid pulling in partially rolled out CUDA Toolkit updates. Meaning we will need to go back through and bump this number when a new CUDA Toolkit becomes available.

xref: #5390

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

Now that a large majority of feedstocks have been rebuilt or have an open migration PR, let's go ahead and close out this PR and add CUDA 12 to the matrix. This adds CUDA 12.0 & CUDA 12.4. Where CUDA 12.0 represents the oldest CUDA 12 version built against and supported in conda-forge. Similarly CUDA 12.4 represents the latest CUDA version in conda-forge. This way if users are still have packages that depend on an older CUDA 12 version, packages built with CUDA 12.0 will satisfy that need. Also if users are trying to take advantage of packages built with the latest optimizations, they can install packages built with the latest CUDA Toolkit in conda-forge. We keep the latest version pinned to avoid pulling in partially rolled out CUDA Toolkit updates. Meaning we will need to go back through and bump this number when a new CUDA Toolkit becomes available.

conda-forge-webservices · 2024-03-09T02:57:23Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham · 2024-03-09T03:00:05Z

cc @conda-forge/core

h-vetinari · 2024-03-09T03:18:03Z

  - 11.2                       # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
  - 11.8                       # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
+  - 12.0                       # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
+  - 12.4                       # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]


Are packages built for 12.0 expected to always successfully build with 12.4? Shouldn't we separate the closing of the 12.0 migration from adding 12.4...?

I remember that in some feedstocks I had to add some code to explicitly use 12.0 to compile. This code should work with 12.4 but as it is not tested, I would feel better if we had a migrator first.

h-vetinari

I don't think we should add 12.4 here; I'd be open to dropping 11.2 in the same PR though.

h-vetinari · 2024-03-11T07:14:23Z

+  # case: native compilation (build == target)
+  - quay.io/condaforge/linux-anvil-ppc64le         # [ppc64le and os.environ.get("BUILD_PLATFORM") == "linux-ppc64le"]
+  - quay.io/condaforge/linux-anvil-aarch64         # [aarch64 and os.environ.get("BUILD_PLATFORM") == "linux-aarch64"]
+  # case: cross-compilation (build != target)
+  - quay.io/condaforge/linux-anvil-cos7-x86_64     # [ppc64le and os.environ.get("BUILD_PLATFORM") == "linux-64"]
+  - quay.io/condaforge/linux-anvil-cos7-x86_64     # [aarch64 and os.environ.get("BUILD_PLATFORM") == "linux-64"]


I'm also pretty sure that the selectors here need os.environ.get("CF_CUDA_ENABLED", "False") == "True" (which was active in the migrator through the selector on docker_images).

h-vetinari · 2024-04-07T08:41:05Z

I think we should move forward here with dropping 11.2 and adding 12.0. Let's split off 12.4.

h-vetinari

The announced date for dropping 11.2 has now passed; given that and the various unanswered review requests here, I've opened #5799 which builds on this PR and incorporates them.

h-vetinari · 2024-04-23T03:48:36Z

+  - 12                         # [os.environ.get("cf_cuda_enabled", "false") == "true" and linux]
+  - 12                         # [os.environ.get("cf_cuda_enabled", "false") == "true" and linux]


This is incorrectly lower-cased here (that environment variable is not set by smithy)

h-vetinari · 2024-04-23T03:51:49Z

+  - 12.4                       # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
 cuda_compiler_version_min:
  - None                       # [osx]
  - 11.2                       # [linux or win64]


This also needs to be bumped (assuming we drop CUDA 11.2 here).

h-vetinari · 2024-05-01T20:49:07Z

If you plan to rebase this PR now that #5799 is in, you can effectively condense it to a revert of 688ab0d (at least for 12.0; you'd have to add the 12.4 changes on top, though I still don't think they belong into this PR)

h-vetinari · 2024-05-15T03:42:15Z

@jakirkham, what's the status here? What still needs to be done from your POV? (since you asked not to close this migration as part of #5799)

h-vetinari · 2024-06-03T07:42:19Z

@jakirkham, what's the status here? What still needs to be done from your POV?

Gentle ping on this

h-vetinari · 2024-08-09T07:43:30Z

I've opened a new PR for this in #6263

kkraus14 · 2024-09-23T03:50:54Z

Made obsolete by #6263

jakirkham mentioned this pull request Mar 9, 2024

CUDA 12 version in cbc.yaml - plans? #5390

Closed

h-vetinari reviewed Mar 9, 2024

View reviewed changes

h-vetinari reviewed Mar 11, 2024

View reviewed changes

mariusvniekerk approved these changes Mar 20, 2024

View reviewed changes

h-vetinari mentioned this pull request Apr 23, 2024

Drop CUDA 11.2 #5799

Merged

h-vetinari requested changes Apr 23, 2024

View reviewed changes

h-vetinari reviewed Apr 23, 2024

View reviewed changes

h-vetinari mentioned this pull request Jul 23, 2024

feat: yet another attempt to add windows builds conda-forge/pytorch-cpu-feedstock#231

Merged

5 tasks

h-vetinari mentioned this pull request Aug 9, 2024

Close CUDA 12 migration (redux) #6263

Merged

17 tasks

kkraus14 closed this Sep 23, 2024

h-vetinari mentioned this pull request Oct 31, 2024

Migrate for CUDA 12.x (x to be determined) #6630

Closed

		- 12 # [os.environ.get("cf_cuda_enabled", "false") == "true" and linux]
		- 12 # [os.environ.get("cf_cuda_enabled", "false") == "true" and linux]

Uh oh!

Conversation

jakirkham commented Mar 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-webservices Bot commented Mar 9, 2024

Uh oh!

jakirkham commented Mar 9, 2024

Uh oh!

h-vetinari Mar 9, 2024

Choose a reason for hiding this comment

Uh oh!

xhochy Mar 10, 2024

Choose a reason for hiding this comment

Uh oh!

h-vetinari left a comment

Choose a reason for hiding this comment

Uh oh!

h-vetinari Mar 11, 2024

Choose a reason for hiding this comment

Uh oh!

h-vetinari commented Apr 7, 2024

Uh oh!

h-vetinari left a comment

Choose a reason for hiding this comment

Uh oh!

h-vetinari Apr 23, 2024

Choose a reason for hiding this comment

Uh oh!

h-vetinari Apr 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

h-vetinari commented May 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

h-vetinari commented May 15, 2024

Uh oh!

h-vetinari commented Jun 3, 2024

Uh oh!

h-vetinari commented Aug 9, 2024

Uh oh!

kkraus14 commented Sep 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jakirkham commented Mar 9, 2024 •

edited

Loading

h-vetinari Apr 23, 2024 •

edited

Loading

h-vetinari commented May 1, 2024 •

edited

Loading