Skip to content

backport natural earth download URL#116

Merged
xylar merged 2 commits intoconda-forge:masterfrom
akrherz:patch_downloader
Sep 3, 2021
Merged

backport natural earth download URL#116
xylar merged 2 commits intoconda-forge:masterfrom
akrherz:patch_downloader

Conversation

@akrherz
Copy link
Copy Markdown
Contributor

@akrherz akrherz commented Sep 3, 2021

Pull in patch from SciTools/cartopy#1833

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The source section contained an unexpected subsection name. patch is not a valid subsection name.

@conda-forge-linter
Copy link
Copy Markdown

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@akrherz
Copy link
Copy Markdown
Contributor Author

akrherz commented Sep 3, 2021

@conda-forge-admin, please rerender

@akrherz
Copy link
Copy Markdown
Contributor Author

akrherz commented Sep 3, 2021

Hmmm, rerendering brought in proj 8, which will not work.

@akrherz
Copy link
Copy Markdown
Contributor Author

akrherz commented Sep 3, 2021

I am unsure what to do here. I believe my patch is applying cleanly and at least Linux builds are happy. The failures are unrelated to my patch it seems.

@zklaus
Copy link
Copy Markdown

zklaus commented Sep 3, 2021

@akrherz, it seems like you need another runtime package for windows. Try adding the following to the requirements/run section of the meta.yaml:

    - ucrt  # [win]

@akrherz
Copy link
Copy Markdown
Contributor Author

akrherz commented Sep 3, 2021

it seems like you need another runtime package for windows.

🙏 Thank you! CI is Green! 🚀

@xylar
Copy link
Copy Markdown
Contributor

xylar commented Sep 3, 2021

Thanks @akrherz and @zklaus! I'll go ahead and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants