Skip to content

version bump (edit: BLIS v2.0)#35

Closed
chillenb wants to merge 5 commits into
conda-forge:mainfrom
chillenb:v1.0
Closed

version bump (edit: BLIS v2.0)#35
chillenb wants to merge 5 commits into
conda-forge:mainfrom
chillenb:v1.0

Conversation

@chillenb

@chillenb chillenb commented Jun 22, 2024

Copy link
Copy Markdown

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices

conda-forge-webservices Bot commented Jun 22, 2024

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@chillenb

Copy link
Copy Markdown
Author

@conda-forge-admin, please rerender

@chillenb

Copy link
Copy Markdown
Author

oops

@conda-forge-admin, please rerender

@chillenb

Copy link
Copy Markdown
Author

Windows build failing :(

clang.exe -ID:/bld/blis_1719077948054/_h_env/Library/include -O2 -D_CRT_SECURE_NO_WARNINGS -D_MT -D_DLL -nostdlib -Xclang --dependent-lib=msvcrt -fuse-ld=lld -pthread -Iinclude/x86_64 -I./frame/include -I./frame/compat/cblas/src/ -DBLIS_IS_BUILDING_LIBRARY -c kernels/sandybridge/3/bli_gemm_sandybridge_int_d8x4.c -o obj/x86_64/kernels/sandybridge/3/bli_gemm_sandybridge_int_d8x4.o

kernels/sandybridge/3/bli_gemm_sandybridge_int_d8x4.c:76:2: error: use of undeclared identifier '__m256d'
   76 |         __m256d va0_3, va4_7;
      |   

@gdonval gdonval marked this pull request as draft June 22, 2024 19:42
@chillenb

Copy link
Copy Markdown
Author

@gdonval @isuruf any idea what is going wrong with the windows build? No march flags are getting passed to the compiler.

@h-vetinari

Copy link
Copy Markdown
Member

@gdonval @isuruf any idea what is going wrong with the windows build? No march flags are getting passed to the compiler.

That sounds like you're missing an include of immintrin.h (or some of the other intrinsics headers) somewhere.

@chillenb chillenb changed the title version bump version bump (edit: BLIS v2.0) Jul 2, 2025
@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [11]

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16037356073. Examine the logs at this URL for more detail.

@conda-forge-admin

Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@chillenb chillenb marked this pull request as ready for review July 10, 2025 21:58
@h-vetinari

Copy link
Copy Markdown
Member

Hey @chillenb, I apologise that this got lost in the flood of notifications. Would you be willing to join as a maintainer on this feedstock?

Comment thread recipe/meta.yaml

build:
number: 2
skip: true # [win]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix this rather than skip it (or provide a very good reason why not; a missing header is not that - that can be patched very easily)

@chillenb

chillenb commented Nov 3, 2025

Copy link
Copy Markdown
Author

Sure, it'd be an honor.
We should definitely be able to get windows to work; AOCL is modified BLIS and it compiles fine.

@h-vetinari

Copy link
Copy Markdown
Member

Great! If you could remove the skip for windows, add yourself under recipe-maintainers: and then rerender + bring CI back to green, I'd happily review & merge!

@mgorny mgorny mentioned this pull request Nov 10, 2025
5 tasks
@isuruf isuruf closed this in #43 Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants