Skip to content

loosen assert on resource names #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
h-vetinari merged 1 commit into from
Nov 7, 2025
Merged

loosen assert on resource names #1744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions conda_forge_admin_requests/access_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,9 @@ def _process_request_for_feedstock(

for resource in resources:
register_ci_cmd.extend(["--cirun-resources", resource])
assert resource.startswith("cirun-openstack"), f"Unknown resource {resource}"
assert resource.startswith("cirun-"), f"Unknown resource {resource}"

# this part is specific to github.com/Quansight/open-gpu-server
if all(resource.startswith("cirun-openstack") for resource in resources):
for key, value in DEFAULT_CIRUN_OPENSTACK_VALUES.items():
for arg in value:
Expand Down Expand Up @@ -255,7 +256,7 @@ def check(request: Dict[str, Any]) -> None:
resources = request["resources"]
assert resources, "Empty resources"
for resource in resources:
assert resource.startswith("cirun-openstack")
assert resource.startswith("cirun-")

if action == "travis":
assert not request.get("revoke", False)
Expand Down
Loading