loosen assert on resource names#1744
Merged
Merged
Conversation
Member
Author
|
Will deploy this now to unblock the situation for pytorch on osx, but please feel free to review this post-merge at your convenience @jaimergp |
h-vetinari
commented
Nov 7, 2025
Comment on lines
167
to
168
| else: | ||
| assert False, f"Unknown resources {resources}" |
Member
Author
There was a problem hiding this comment.
Sigh, I hadn't noticed the else branch; follow-up fix in da8b21e
Member
Author
|
Well; this ran through now, but the logs show absolutely no indication of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1743, which fails to deploy because the resource name (correctly) doesn't start with
cirun-openstack: