libxml2: fix FreeBSD #3953
Merged
libxml2: fix FreeBSD #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically created by bincrafters-conventions 0.30.1
ghost
mentioned this pull request
|
I detected other pull requests that are modifying libxml2/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
ghost
mentioned this pull request
4 tasks
Croydon
approved these changes
Dec 18, 2020
|
All green in build 2 (
|
theirix
reviewed
Dec 18, 2020
| @@ -255,7 +255,7 @@ def package_info(self): | |||
| self.output.info("Appending PATH environment variable: {}".format(bindir)) | |||
| self.env_info.PATH.append(bindir) | |||
|
|
|||
| if self.settings.os == "Linux" or self.settings.os == "Macos": | |||
| if self.settings.os in ["Linux", "Macos", "FreeBSD"]: | |||
There was a problem hiding this comment.
Maybe just put it in else block for a if self.settings.os == "Windows"?
There was a problem hiding this comment.
I"m not sure, but m can also be used with mingw.
So testing for Windows is not enough.
There was a problem hiding this comment.
That's correct. Mingw makes life harder.
There was a problem hiding this comment.
I'm not sure either, it's usually better to be explicit in this case
prince-chrismc
approved these changes
Dec 20, 2020
SSE4
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: libxml2/*
conan-center hook activated.