libxml2: fix mingw on Linux + double quotes + libxml2 does not create cmake targets #2714

madebr · 2020-08-29T17:22:18Z

Specify library name and version: libxml2/all

Fixes #2708
@SpaceIm

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2020-08-29T17:53:32Z

All green in build 1 (c61a2382255481a45e5b89a223a12fb5918b7cb0)! 😊

libxml2/2.9.9: Generated 82 packages. All logs here
libxml2/2.9.10: Generated 82 packages. All logs here

recipes/libxml2/all/conanfile.py

SpaceIm · 2020-08-29T18:36:33Z

Could you also bump msys2 and icu versions please?

SpaceIm · 2020-08-29T18:37:06Z

recipes/libxml2/all/conanfile.py

        if self.settings.os == "Linux" or self.settings.os == "Macos":
-            self.cpp_info.system_libs.append('m')


Is it really required for Macos?

I don't know of another recipe that adds m for Macos.
I can't check it...

that's good catch, it shouldn't be needed on macOS - everything reside in libSystem.dylib

recipes/libxml2/all/conanfile.py

conan-center-bot · 2020-08-30T00:04:39Z

All green in build 2 (42191a9caad0c63f8daea1f6cb7ff4130bb24603)! 😊

libxml2/2.9.9: Generated 82 packages. All logs here
libxml2/2.9.10: Generated 82 packages. All logs here

recipes/libxml2/all/conanfile.py

madebr · 2020-09-24T23:49:42Z

@SpaceIm @danimtb @prince-chrismc
Can this pr receive some reviews please?

prince-chrismc · 2020-09-25T00:13:43Z

recipes/libxml2/all/conanfile.py

+                ext = ".exe" if self.settings.os == "Windows" else ""
+                autotools.make(["xmllint" + ext, "xmlcatalog" + ext, "xml2-config"])


Could be a function since it's duplicated here

prince-chrismc · 2020-09-25T00:18:54Z

recipes/libxml2/all/conanfile.py

            if not self.options.shared:
                os.unlink(os.path.join(self.package_folder, "bin", "libxml2.dll"))
-            os.unlink(os.path.join(self.package_folder, 'lib', 'libxml2_a_dll.lib'))
-            os.unlink(os.path.join(self.package_folder, 'lib', 'libxml2_a.lib' if self.options.shared else 'libxml2.lib'))
+            os.unlink(os.path.join(self.package_folder, "lib", "libxml2_a_dll.lib"))
+            os.unlink(os.path.join(self.package_folder, "lib", "libxml2_a.lib" if self.options.shared else "libxml2.lib"))


This bit is a little confusing

shared --> remove dll
remove _a_ dll
shared --> remove _a_ lib
static--> remove lib ???

That's weird, but it works. After this cleanup, only relevant static or import lib remains.

recipes/libxml2/all/conanfile.py

prince-chrismc · 2020-09-25T00:26:53Z

There's only one component which looks like the default target. Was the motivation for the CMake components the extra "FIXME"s?

SpaceIm · 2020-09-25T09:44:58Z

On my MinGW@windows, static works, but not shared:

libxml2/2.9.10: run_in_windows_bash: C:\Users\spaceim\.conan_short\da178f\1\bin\usr\bin\bash.exe --login -c ^"cd \^"/c/users/spaceim/.conan/data/libxml2/2.9.10/_/_/build/1266ee60dda1924524275f8c386c3fd96c94fccf\^" ^&^& PATH=\^"/c/users/spaceim/.conan_short/da178f/1/bin/usr/bin:/c/users/spaceim/.conan/data/libiconv/1.16/_/_/package/bd8676182f1db70e6be16a57c45604fb7a6b0978/bin:$PATH\^" ^&^& make xmllint.exe xmlcatalog.exe xml2-config -j4 ^"
libxml2/2.9.10:   CC       xmllint.o
libxml2/2.9.10: make: « xml2-config » est à jour.
libxml2/2.9.10:   CC       xmlcatalog.o
libxml2/2.9.10:   CCLD     xmlcatalog.exe
libxml2/2.9.10:   CCLD     xmllint.exe
libxml2/2.9.10: c:/mingw/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: xmlcatalog.o:xmlcatalog.c:(.text+0x502): undefined reference to `__imp_xmlFree'
libxml2/2.9.10: c:/mingw/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: xmlcatalog.o:xmlcatalog.c:(.text.startup+0x1eb): undefined reference to `__imp_xmlFree'
libxml2/2.9.10: collect2.exe: error: ld returned 1 exit status
libxml2/2.9.10: make: *** [Makefile:1148 : xmlcatalog.exe] Erreur 1
libxml2/2.9.10: make: *** Attente des tâches non terminées....
libxml2/2.9.10: c:/mingw/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: xmllint.o:xmllint.c:(.text+0xac5): undefined reference to `__imp_xmlFree'
libxml2/2.9.10: c:/mingw/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: xmllint.o:xmllint.c:(.text+0xc6f): undefined reference to `__imp_xmlFree'
libxml2/2.9.10: c:/mingw/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: xmllint.o:xmllint.c:(.text+0xd20): undefined reference to `__imp_xmlFree'
libxml2/2.9.10: c:/mingw/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: xmllint.o:xmllint.c:(.text+0xf2e): undefined reference to `__imp_xmlFree'
libxml2/2.9.10: c:/mingw/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: xmllint.o:xmllint.c:(.text+0x2f24): undefined reference to `__imp_xmlFree'
libxml2/2.9.10: c:/mingw/bin/../lib/gcc/x86_64-w64-mingw32/9.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: xmllint.o:xmllint.c:(.text+0x49b9): more undefined references to `__imp_xmlFree' follow
libxml2/2.9.10: collect2.exe: error: ld returned 1 exit status
libxml2/2.9.10: make: *** [Makefile:1152 : xmllint.exe] Erreur 1
libxml2/2.9.10:

Maybe msys2/MSYS2-packages#171 or msys2/MSYS2-packages#1917 could help?

Would it work again by reverting MinGW modifications in #2149 (call Makefile.mingw again: e9e2843) ?

recipes/libxml2/all/conanfile.py

SpaceIm · 2020-09-25T11:22:57Z

recipes/libxml2/all/conanfile.py

+
+        self.cpp_info.components["xml2lib"].names["pkg_config"] = "libxml-2.0"
+        self.cpp_info.filenames["cmake_find_package"] = "LibXml2"
+        self.cpp_info.filenames["cmake_find_package_multi"] = "LibXml2"


So why not libxml2 (for cmake_find_package_multi only)?

Ok, I'll remove the cmake_find_package.

why removing cmake_find_package? I'm a little bit lost.

I just checked a output and the configuration creates libxml2-config.cmake.
So, as you said, it should set the cmake_find_package_multi name to libxml2.
So I think cmake_find_package should not be set.
Or should it be set to a hidden name? Like _libxml2.
Or should it be set to the same name as cmake_find_package_multi?

LibXml2 for cmake_find_package is fine: https://cmake.org/cmake/help/latest/module/FindLibXml2.html

But all of this (module and config) doesn't require components (except if you anticipate "executable components")

So to resume:

cmake_find_package:

filename: LibXml2

importedtarget: LibXml2::LibXml2

cmake_find_package_multi:

filename: libxml2

importedtarget: whatever you want (let's say LibXml2::LibXml2)

SpaceIm · 2020-09-25T12:56:00Z

@madebr please consider madebr#12

recipes/libxml2/all/conanfile.py

madebr · 2020-09-25T14:06:36Z

@SpaceIm

Does it not work on mingw@windows for you?

Maybe msys2/MSYS2-packages#171 or msys2/MSYS2-packages#1917 could help?

Would it work again by reverting MinGW modifications in #2149 (call Makefile.mingw again: e9e2843) ?

I don't think you added IN_LIBXML to cxxflags.

conan-center-bot · 2020-09-25T14:15:05Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2020-10-05T15:14:00Z

Some configurations of 'libxml2/2.9.9' failed in build 6 (4f7f93cb0dc3c8d9fac1d796ec0680f243fef70e):

Linux x86_64, Release, clang 4.0, libstdc++ . Options: libxml2:shared-False
Access to all the logs

SpaceIm · 2020-10-06T09:30:39Z

@SpaceIm
Does it not work on mingw@windows for you?

This is for #2708. For you own bug report btw.

Maybe msys2/MSYS2-packages#171 or msys2/MSYS2-packages#1917 could help?
Would it work again by reverting MinGW modifications in #2149 (call Makefile.mingw again: e9e2843) ?

I don't think you added IN_LIBXML to cxxflags.

IN_LIBXML is used for building to choose __declspec(dllexport) while building a shared build vs using __declspec(dllimport) when using a shared library.
LIBXML_STATIC should do the job.

Sorry I don't understand. With my MinGW, libxml2 shared doesn't work with autotools, this why I've restored makefile.mingw build.
Do you mean that libxml2 shared could work with autotools and some modifications based on IN_LIBXML?

… targets

…orrect library for utils

madebr · 2020-11-01T02:08:40Z

Sorry I don't understand. With my MinGW, libxml2 shared doesn't work with autotools, this why I've restored makefile.mingw build.
Do you mean that libxml2 shared could work with autotools and some modifications based on IN_LIBXML?

@SpaceIm
~~I think you were correct. IN_LIBXML was needed + the utils linked to the wrong library (it selected the import library instead of the static library).~~
When looking at the c sources of libxml2, it looks like the libraries have #define IN_LIBXML defined at the top.

While trying out #3314 on mingw@Windows, I needed to apply these patches to libxml2 (libxml2 is a dependency of xmlsec)

Can you please review?

conan-center-bot · 2020-11-01T02:24:42Z

Some configurations of 'libxml2/2.9.9' failed in build 8 (cb50a554fcee34395bd8d024bd123033ef789337):

Linux x86_64, Debug, clang 3.9, libstdc++ . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 3.9, libstdc++ . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 3.9, libstdc++ . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, clang 8, libstdc++ . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 7, libstdc++11 . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 9, libstdc++11 . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 8, libstdc++11 . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 5, libstdc++11 . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 6, libstdc++11 . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 7, libstdc++11 . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 5, libstdc++11 . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, clang 5.0, libstdc++ . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 8, libstdc++11 . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, gcc 6, libstdc++11 . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, clang 7.0, libstdc++ . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, clang 3.9, libstdc++ . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, clang 9, libstdc++ . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 6, libstdc++11 . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 9, libstdc++ . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 9, libstdc++11 . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 8, libstdc++ . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 7.0, libstdc++ . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 9, libstdc++ . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 9, libstdc++11 . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 6.0, libstdc++ . Options: libxml2:shared-False
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 7.0, libstdc++ . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 6.0, libstdc++ . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 8, libstdc++ . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 5, libstdc++11 . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, clang 5.0, libstdc++ . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Release, gcc 7, libstdc++11 . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, clang 5.0, libstdc++ . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, clang 6.0, libstdc++ . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs
Linux x86_64, Debug, clang 4.0, libstdc++ . Options: libxml2:shared-True
- Log download
- Log error Download
- Profile
Access to all the logs

ghost · 2020-11-16T08:54:36Z

I detected other pull requests that are modifying libxml2/all recipe:

libxml2: fix FreeBSD #3953

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

stale · 2020-12-17T17:10:59Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-01-17T19:34:35Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

SSE4 requested review from uilianries and danimtb August 29, 2020 17:59

SSE4 previously approved these changes Aug 29, 2020

View reviewed changes

SpaceIm reviewed Aug 29, 2020

View reviewed changes

recipes/libxml2/all/conanfile.py Outdated Show resolved Hide resolved

conan-io deleted a comment from madebr Aug 29, 2020

SpaceIm reviewed Aug 29, 2020

View reviewed changes

recipes/libxml2/all/conanfile.py Outdated Show resolved Hide resolved

madebr dismissed SSE4’s stale review via 42191a9 August 29, 2020 23:40

danimtb previously approved these changes Aug 31, 2020

View reviewed changes

madebr commented Sep 1, 2020

View reviewed changes

recipes/libxml2/all/conanfile.py Outdated Show resolved Hide resolved

madebr dismissed danimtb’s stale review via aa19cc8 September 1, 2020 15:06

uilianries previously approved these changes Sep 3, 2020

View reviewed changes

prince-chrismc reviewed Sep 25, 2020

View reviewed changes

recipes/libxml2/all/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed Sep 25, 2020

View reviewed changes

recipes/libxml2/all/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed Sep 25, 2020

View reviewed changes

madebr dismissed uilianries’s stale review via 84b3155 September 25, 2020 13:58

madebr commented Sep 25, 2020

View reviewed changes

recipes/libxml2/all/conanfile.py Show resolved Hide resolved

madebr commented Sep 25, 2020

View reviewed changes

recipes/libxml2/all/conanfile.py Outdated Show resolved Hide resolved

conan-center-bot added the Unexpected Error label Sep 25, 2020

conan-center-bot added Failed and removed Unexpected Error labels Oct 5, 2020

madebr force-pushed the libxml2_mingw branch from 4f7f93c to 3638f6d Compare October 5, 2020 15:17

madebr and others added 11 commits November 1, 2020 00:33

libxml2: fix mingw on Linux + double quotes + libxml2 does not create…

aef76c9

… targets

libxml2: bump dependencies

5b64a9b

libxml2: create FindLibXml2.cmake package (cmake spec)

2b77736

libxml2: only linux needs m

c56f0b9

libxml2: restore specific mingw build

0219b1c

libxml2: reorder methods

574c61e

libxml2: finer grain cleanup during packaging

4c44fe9

libxml2: improve system libs

6d4440a

libxml2: avoid creating multiple .pc files

7a3f466

libxml2: no components + updated cmake_find_package_* names

2234d5b

libxml2: fix CC/LD/AR on mingw@Windows + pass -DIN_LIBXML + link to c…

cb50a55

…orrect library for utils

madebr force-pushed the libxml2_mingw branch from 3638f6d to cb50a55 Compare November 1, 2020 02:07

ericLemanissier mentioned this pull request Nov 12, 2020

[service] Potentially conflicting recipes #3517

Closed

This was referenced Nov 16, 2020

[service] Potentially conflicting recipes #3571

Closed

libxml2: don't set LIBS environment variable for autotools #3080

Merged

stale bot added the stale label Dec 17, 2020

ghost mentioned this pull request Dec 18, 2020

libxml2: fix FreeBSD #3953

Merged

4 tasks

ghost mentioned this pull request Jan 4, 2021

libxml2 have to explicitly link the math lib on Android #4080

Merged

4 tasks

stale bot closed this Jan 17, 2021

SpaceIm mentioned this pull request Feb 20, 2021

libxml2: provide official CMake variables + del fPIC if shared + fix system libs #4625

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libxml2: fix mingw on Linux + double quotes + libxml2 does not create cmake targets #2714

libxml2: fix mingw on Linux + double quotes + libxml2 does not create cmake targets #2714

madebr commented Aug 29, 2020

conan-center-bot commented Aug 29, 2020

SpaceIm commented Aug 29, 2020

SpaceIm Aug 29, 2020

madebr Aug 29, 2020

SSE4 Aug 31, 2020

conan-center-bot commented Aug 30, 2020

madebr commented Sep 24, 2020

prince-chrismc Sep 25, 2020

prince-chrismc Sep 25, 2020

SpaceIm Sep 25, 2020

prince-chrismc commented Sep 25, 2020

SpaceIm commented Sep 25, 2020 •

edited

Loading

SpaceIm Sep 25, 2020 •

edited

Loading

madebr Sep 25, 2020

SpaceIm Sep 25, 2020

madebr Sep 25, 2020

SpaceIm Sep 25, 2020 •

edited

Loading

SpaceIm commented Sep 25, 2020

madebr commented Sep 25, 2020

conan-center-bot commented Sep 25, 2020

conan-center-bot commented Oct 5, 2020

SpaceIm commented Oct 6, 2020 •

edited

Loading

madebr commented Nov 1, 2020 •

edited

Loading

conan-center-bot commented Nov 1, 2020

ghost commented Nov 16, 2020 •

edited by ghost

Loading

stale bot commented Dec 17, 2020

stale bot commented Jan 17, 2021

		if self.settings.os == "Linux" or self.settings.os == "Macos":
		self.cpp_info.system_libs.append('m')

		ext = ".exe" if self.settings.os == "Windows" else ""
		autotools.make(["xmllint" + ext, "xmlcatalog" + ext, "xml2-config"])

libxml2: fix mingw on Linux + double quotes + libxml2 does not create cmake targets #2714

libxml2: fix mingw on Linux + double quotes + libxml2 does not create cmake targets #2714

Conversation

madebr commented Aug 29, 2020

conan-center-bot commented Aug 29, 2020

SpaceIm commented Aug 29, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Aug 30, 2020

madebr commented Sep 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prince-chrismc commented Sep 25, 2020

SpaceIm commented Sep 25, 2020 • edited Loading

SpaceIm Sep 25, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SpaceIm Sep 25, 2020 • edited Loading

Choose a reason for hiding this comment

SpaceIm commented Sep 25, 2020

madebr commented Sep 25, 2020

conan-center-bot commented Sep 25, 2020

conan-center-bot commented Oct 5, 2020

SpaceIm commented Oct 6, 2020 • edited Loading

madebr commented Nov 1, 2020 • edited Loading

conan-center-bot commented Nov 1, 2020

ghost commented Nov 16, 2020 • edited by ghost Loading

stale bot commented Dec 17, 2020

stale bot commented Jan 17, 2021

SpaceIm commented Sep 25, 2020 •

edited

Loading

SpaceIm Sep 25, 2020 •

edited

Loading

SpaceIm Sep 25, 2020 •

edited

Loading

SpaceIm commented Oct 6, 2020 •

edited

Loading

madebr commented Nov 1, 2020 •

edited

Loading

ghost commented Nov 16, 2020 •

edited by ghost

Loading