-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libselinux: Fix cross-compilation #22952
libselinux: Fix cross-compilation #22952
Conversation
This comment has been minimized.
This comment has been minimized.
Apply patches for 3.6 to fix detection of available functions when cross-compiling. Use the PKG_CONFIG_LIBDIR to point pkg-config to the correct directory containing Conan's generated pkg-config files. Without this, the pcre2 from the system will be picked up before the one provided by Conan. When cross-compiling, this causes system include directories to poison the build.
8376f94
to
36cc7d6
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jwillikers Thanks a lot for this PR (and the associated issue 😁 )
Sorry for the huge delay! I'm just revisiting all my old assigned issues! 🙏
LGTM! I only have a question regarding to the environment.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 5 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Apply patches for 3.6 to fix detection of available functions when cross-compiling. Use the
PKG_CONFIG_LIBDIR
to point pkg-config to the correct directory containing Conan's generated pkg-config files. Without this, thepcre2
from the system will be picked up before the one provided by Conan. When cross-compiling, this causes system include directories to poison the build.libselinux-3.6-cross-fixed-log.txt
libselinux-3.6-cross-broken-log.txt