Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libselinux): add patch to link with pcre2 from conan instead of o… #19123

Merged

Conversation

ledocc
Copy link
Contributor

@ledocc ledocc commented Aug 9, 2023

…ne from system

Specify library name and version: libselinux/3.3

Problem:
On my centos 7.9 docker image, I have not libpcre2-8.so installed.
When package libselinux build, utils executables failed to link with libselinux because libpcre2-8 is not found.

Explication:
In the libselinux Makefile, libselinux.so library link with libpcre2-8.so.
Then executables in utils sub-directory are compiled and linked with libselinux.so. But on link command line, no information were provide to find libselinux dependencies (ex: -L/path/to/pcre2/lib_directory), so linker look for libpcre2 on the system, and this work fine in many case ... excepted when libpcre2-8.so in not installed on the system

Solution:
Provided information to linker to find libselinux dependencies.

Info:
Executables in utils sub-directory are not installed in libselinux package, so we could :

  • patch the Makefile to disable the build utils sub-directory
  • remove utils sub-directory before run the build
  • any other solution to not build utils sub-directory
  • do nothing
  • add them to package

thought ?

@Tobulus
Copy link
Contributor

Tobulus commented Aug 9, 2023

Hi @ledocc
This sounds like it could potentially also fix this issue here: #15798

I can check this tomorrow :)

@Tobulus
Copy link
Contributor

Tobulus commented Aug 10, 2023

Hi @ledocc This sounds like it could potentially also fix this issue here: #15798

I can check this tomorrow :)

Yep, its fixing the problem. Thanks!

@ghost
Copy link

ghost commented Aug 16, 2023

I detected other pull requests that are modifying libselinux/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Aug 24, 2023
3 tasks
@Tobulus
Copy link
Contributor

Tobulus commented Sep 11, 2023

Conan v1 pipeline ❌

Failure in build 1 (843b43a560a1d18f0851e70f8be92e68cd7a7079):

An unexpected error happened and has been reported. Help is on its way! 🏇

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 1 (843b43a560a1d18f0851e70f8be92e68cd7a7079):

  • libselinux/3.3@:
    All packages built successfully! (All logs)
  • libselinux/3.2@:
    All packages built successfully! (All logs)
  • libselinux/3.1@:
    All packages built successfully! (All logs)
  • libselinux/3.0@:
    All packages built successfully! (All logs)
  • libselinux/2.9@:
    All packages built successfully! (All logs)

What about this failure? Is someone taking care?
@RubenRBS or someone else

@ghost ghost mentioned this pull request Sep 18, 2023
3 tasks
@Tobulus
Copy link
Contributor

Tobulus commented Oct 15, 2023

Conan v1 pipeline ❌

Failure in build 1 (843b43a560a1d18f0851e70f8be92e68cd7a7079):
An unexpected error happened and has been reported. Help is on its way! 🏇

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 1 (843b43a560a1d18f0851e70f8be92e68cd7a7079):

  • libselinux/3.3@:
    All packages built successfully! (All logs)
  • libselinux/3.2@:
    All packages built successfully! (All logs)
  • libselinux/3.1@:
    All packages built successfully! (All logs)
  • libselinux/3.0@:
    All packages built successfully! (All logs)
  • libselinux/2.9@:
    All packages built successfully! (All logs)

What about this failure? Is someone taking care? @RubenRBS or someone else

@RubenRBS

@conan-center-bot

This comment has been minimized.

danimtb
danimtb previously approved these changes Feb 27, 2024
@conan-center-bot

This comment has been minimized.

2 similar comments
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

3 similar comments
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

There was conflict in this PR.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 10 (b5d0bd4b6c4e859fef5cccb4d369f321c47a8186):

  • libselinux/3.6:
    All packages built successfully! (All logs)

  • libselinux/3.5:
    All packages built successfully! (All logs)

  • libselinux/3.3:
    All packages built successfully! (All logs)

  • libselinux/3.2:
    All packages built successfully! (All logs)

  • libselinux/3.0:
    All packages built successfully! (All logs)

  • libselinux/3.1:
    All packages built successfully! (All logs)

  • libselinux/2.9:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (b5d0bd4b6c4e859fef5cccb4d369f321c47a8186):

  • libselinux/3.5:
    All packages built successfully! (All logs)

  • libselinux/3.6:
    All packages built successfully! (All logs)

  • libselinux/3.2:
    All packages built successfully! (All logs)

  • libselinux/3.1:
    All packages built successfully! (All logs)

  • libselinux/3.3:
    All packages built successfully! (All logs)

  • libselinux/3.0:
    All packages built successfully! (All logs)

  • libselinux/2.9:
    All packages built successfully! (All logs)

@ghost ghost mentioned this pull request Mar 1, 2024
@franramirez688 franramirez688 self-assigned this Mar 1, 2024
@conan-center-bot conan-center-bot merged commit 0577ab4 into conan-io:master Mar 1, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants