-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta qt6 PR #22835
Meta qt6 PR #22835
Conversation
Qt 6.6.0 added `d3d12` to the list of system libraries on Windows it links against: qt/qtbase@84fb0de#diff-2d8b127aed7a6123be24b80481b760ec4e9cc251e19d668d936dc09e87147a0e This is currently breaking the build in conan-io#18794.
d3d12.dll was added with Windows 10. Don't want to potentially limit the range of supported OS versions unnecessarily.
qt_no_debug
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
I detected other pull requests that are modifying qt/6.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Qt6: minor formatting fixes
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 41876aeqt/6.6.0@#bac4461938ab0c7ed23b437df9eaefcf
qt/6.6.2@#b77502dcae9f19ef847f1bd6393dc7c0
qt/6.6.1@#628421be515be9aff36451afdeb658f7
qt/6.5.3@#86d73fbad1196bfd13c3b0985559ad70
qt/6.3.2@#9940811a1c20089b8f4f6cb67e4addcc
qt/6.4.2@#3c39bda0b3d11aa4cc3096f7477a48a2
|
The build is now finished. You can take a look at the results here |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bfe439f
to
025e554
Compare
This comment has been minimized.
This comment has been minimized.
@uilianries @danimtb what's happening here ?
On my machine, running |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <[email protected]>
The build is now finished. You can take a look at the results here |
Conan v1 pipeline ✔️All green in build 12 (
Conan v2 pipeline ✔️
All green in build 12 (
|
Hooks produced the following warnings for commit b4ff473qt/6.6.2@#e1444e010ab3fdd5f82092604caa93bc
qt/6.6.1@#a6ca82cea9584c51e224c5270a2a788a
qt/6.6.0@#6523c75714e57de02c42d487cddb7a25
qt/6.5.3@#2aa61f2eec5babd2403d843d35ecd20d
qt/6.4.2@#b5b6e983433792ac8ce55b685b2402cf
qt/6.3.2@#89875f8f844f146775371714403ce0e8
|
thanks |
* qt: add QT_NO_DEBUG define in release build * fix condition for QT_NO_DEBUG define * Qt6: add d3d12 system lib on Windows Qt 6.6.0 added `d3d12` to the list of system libraries on Windows it links against: qt/qtbase@84fb0de#diff-2d8b127aed7a6123be24b80481b760ec4e9cc251e19d668d936dc09e87147a0e This is currently breaking the build in conan-io#18794. * Qt6: make d3d12 conditional on Qt version d3d12.dll was added with Windows 10. Don't want to potentially limit the range of supported OS versions unnecessarily. * Qt6: update all system dependency lists * Fix a typo * qt6: add tools macros fixes conan-io#22530 * require explicitely gstreamer * bump deps * fix gstreamer consumption * fix cmake_find_mode of deps * Qt6: minor formatting fixes * qt 6.6.2 generated with: conan config install https://github.com/conan-io/conan-extensions.git conan cci:upgrade-qt-recipe 6.6.2 * fix patching * trigger CI without conflict Signed-off-by: Uilian Ries <[email protected]> --------- Signed-off-by: Uilian Ries <[email protected]> Co-authored-by: Alex Maystrenko <[email protected]> Co-authored-by: Martin Valgur <[email protected]> Co-authored-by: Uilian Ries <[email protected]>
Specify library name and version: qt/6.*
This PR gathers the content of the currently opened PRs, hoping to get some attention from the team:
I only used merge commits, so merging this meta-PR automatically closes the PRs above. Also, if one of the PRs above is merged before this meta-PR, I'll simply merge master into this meta-PR and said PR content will disappear from this meta-PR
call for review @conan-io/barbarians