Qt6: ensure system_libs includes all libs linked against by the project #21676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
This was referenced Dec 7, 2023
This comment has been minimized.
This comment has been minimized.
jwillikers
approved these changes
Dec 9, 2023
3 tasks
|
It would be the New Year's miracle if this PR would succeeded 😊 🎄 |
This comment has been minimized.
This comment has been minimized.
MartinDelille
approved these changes
Jan 2, 2024
ghost
mentioned this pull request
3 tasks
Qt 6.6.0 added `d3d12` to the list of system libraries on Windows it links against: qt/qtbase@84fb0de#diff-2d8b127aed7a6123be24b80481b760ec4e9cc251e19d668d936dc09e87147a0e This is currently breaking the build in conan-io#18794.
d3d12.dll was added with Windows 10. Don't want to potentially limit the range of supported OS versions unnecessarily.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit ad656afqt/6.6.0@#710c57ce5cf993362f6b54776a369583qt/6.6.1@#c07c36b0047a7bba3d1ce29cd0007e22qt/6.5.3@#0b2f896df0810fefd011732a3f9968caqt/6.4.2@#d4b7d21cc9c804992ee4bed4b5f7d399qt/6.3.2@#363eea6e74636b8e93cda8f35579494f |
ericLemanissier
approved these changes
Jan 20, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 7a9442aqt/6.6.1@#795859f99ef3e0b2b598307bd689f0eaqt/6.6.0@#85c59c2c9e184900d4b7cecd35fde5dbqt/6.5.3@#648853a858b03ae3f3f139896a8db0c3qt/6.3.2@#f8cc02b67701018f3781e3f08cf91bc2qt/6.4.2@#805d43162ecc442e7b531bb02e8025b3 |
jwillikers
approved these changes
Jan 24, 2024
MartinDelille
approved these changes
Jan 26, 2024
This was referenced Feb 5, 2024
|
Hi, just wondering when this PR will be merged ? |
|
I tested the code on my machine today. Worked for me (Windows 10, MSVC 2022 community). |
fnadeau
approved these changes
Feb 20, 2024
valgur
changed the title
conan-center-bot
added
Failed
Version conflict
Conan v1 pipeline ❌Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
jwillikers
approved these changes
Feb 21, 2024
ghost
mentioned this pull request
3 tasks
|
closed via #22835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qt 6.6.0 added
d3d12to the list of system libraries on Windows it links against: qt/qtbase@84fb0de#diff-2d8b127aed7a6123be24b80481b760ec4e9cc251e19d668d936dc09e87147a0eThis is currently breaking the build in #18794.