Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib/all: bump libgettext #19417

Merged
merged 14 commits into from
Oct 1, 2023
Merged

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Aug 25, 2023

Generated and committed by Conan Center Bump Deps
Find more updatable recipes in the GitHub Pages

Specify library name and version: glib/*


@ericLemanissier ericLemanissier mentioned this pull request Aug 25, 2023
3 tasks
@ghost
Copy link

ghost commented Aug 25, 2023

I detected other pull requests that are modifying glib/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@ericLemanissier ericLemanissier mentioned this pull request Aug 28, 2023
3 tasks
@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AFAIK we want old glib versions to stick around longer than for usual libraries, will check with the team

@AbrilRBS AbrilRBS self-assigned this Aug 29, 2023
@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented Aug 30, 2023

Ok, I don't mind reintroducing some old versions. I just wanted to make the recipe simpler and CI faster.
The bumping of libgettext to 0.22 requires all versions of glib < 2.77.0 to have a patch similar to https://github.com/conan-io/conan-center-index/pull/19417/files#diff-ca617f1863a5ca0283c2450412a0bd09c1fc0ca11b2cb494f4d7245270aef61c and this patch must be tuned for nearly all versions, so each old version we keep around increases the number of patch files

The full picture:

@ghost ghost mentioned this pull request Aug 31, 2023
3 tasks
@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented Sep 6, 2023

@RubenRBS The only dependents that would need to be bumped are livips and pango, but the problem they have do not come from glib.
Do you think we should keep glib/2.73.3 and glib/2.76.1?

@ericLemanissier

This comment was marked as outdated.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented Sep 8, 2023

After checking, I think we're good to remove old versions and keep only the latest patch for each minor, so let's focus on bumping pango and libvips so we can delete those :)

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ericLemanissier
Copy link
Contributor Author

So we are good to go like this?

@ghost ghost mentioned this pull request Sep 11, 2023
3 tasks
@AbrilRBS
Copy link
Member

Yes, but we first need to merge the other PRs you linked beforehand, let me prioritize those

@ghost ghost mentioned this pull request Sep 18, 2023
3 tasks
@ericLemanissier ericLemanissier changed the title glib/all: bump deps glib/all: bump libgettext Sep 18, 2023
@conan-center-bot

This comment has been minimized.

@ericLemanissier
Copy link
Contributor Author

The build is now finished. You can take a look at the results here

@AbrilRBS
Copy link
Member

Will re-trigger after #20218 is merged

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (30025845f2457bdc976ca612fbf379361a0d4d0d):

  • glib/2.77.2:
    All packages built successfully! (All logs)

  • glib/2.78.0:
    All packages built successfully! (All logs)

  • glib/2.77.3:
    All packages built successfully! (All logs)

  • glib/2.77.1:
    All packages built successfully! (All logs)

  • glib/2.77.0:
    All packages built successfully! (All logs)

  • glib/2.76.3:
    All packages built successfully! (All logs)

  • glib/2.75.3:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 11 (30025845f2457bdc976ca612fbf379361a0d4d0d):

  • glib/2.78.0:
    All packages built successfully! (All logs)

  • glib/2.77.3:
    All packages built successfully! (All logs)

  • glib/2.77.2:
    All packages built successfully! (All logs)

  • glib/2.77.0:
    All packages built successfully! (All logs)

  • glib/2.77.1:
    All packages built successfully! (All logs)

  • glib/2.76.3:
    All packages built successfully! (All logs)

  • glib/2.75.3:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit ac3227c into conan-io:master Oct 1, 2023
@ericLemanissier ericLemanissier deleted the glib branch October 1, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants